Optimize state sync

[AllFi]

No description provided.

[EvgenKor]

No issues were found. Need to increase minor version (-> 0.3.10) for libzkbob-rs and libzkbob-rs-wasm

[lok52]

Why we need to insert new commitments each time after notes or an account is decrypted?

libzkbob-rs/libzkbob-rs-wasm/src/client/mod.rs

Lines 304 to 307 in 2537c16

	if other_tx_commitments.len() > 0 {
	let commitments = other_tx_commitments.drain(..);
	self.inner.borrow_mut().state.tree.add_tx_commitments(other_tx_start_index.unwrap(), commitments);
	}

libzkbob-rs/libzkbob-rs-wasm/src/client/mod.rs

Lines 353 to 356 in 2537c16

	if other_tx_commitments.len() > 0 {
	let commitments = other_tx_commitments.drain(..);
	self.inner.borrow_mut().state.tree.add_tx_commitments(other_tx_start_index.unwrap(), commitments);
	}

Doesn't this part cover this case?

libzkbob-rs/libzkbob-rs-wasm/src/client/mod.rs

Lines 382 to 385 in 2537c16

	if other_tx_commitments.len() > 0 {
	let commitments = other_tx_commitments.drain(..);
	self.inner.borrow_mut().state.tree.add_tx_commitments(other_tx_start_index.unwrap(), commitments);
	}

[AllFi]

It is necessary because we need to have correct merkle tree state before calling add_full_tx. It makes sense to update merkle tree only once with tx commitments of others' transactions and leafs of our transactions. But such approach requires rethinking of the whole process of merkle tree updating, so I have decided to leave it to upcoming updates.