Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Rate box disappers on small screen #11084

Closed
adamPetho opened this issue Jul 21, 2023 · 11 comments · Fixed by #11137
Closed

Exchange Rate box disappers on small screen #11084

adamPetho opened this issue Jul 21, 2023 · 11 comments · Fixed by #11137
Assignees
Labels

Comments

@adamPetho
Copy link
Collaborator

adamPetho commented Jul 21, 2023

General Description

The BTC/USD exchange rate box vanishes on small screen.

Smallest possible Wasabi on laptop monitor.
Resolution: 1920x1080

How To Reproduce?

  1. Make the Wasabi window small.
  2. See that there is no BTC/USD exchange rate box.
  3. make Wasabi full screen.
  4. See that the exchange rate box is there.

Screenshots

On small:
image

Fullscreen:
image

Operating System

Win11

@soosr
Copy link
Collaborator

soosr commented Jul 21, 2023

I cannot reproduce it

@adamPetho
Copy link
Collaborator Author

@yahiheb @MarnixCroes @Szpoti can someone reproduce this? If it's only happening on my PC, then feel free to close this issue.

@turbolay
Copy link
Collaborator

turbolay commented Jul 21, 2023

can't repro on mac, even changing the resolution

@MarnixCroes
Copy link
Collaborator

I could not

@yahiheb
Copy link
Collaborator

yahiheb commented Jul 21, 2023

I can reproduce it when I change the display resolution to 1920x1080.

Win10.

@Szpoti
Copy link
Collaborator

Szpoti commented Jul 24, 2023

Can't repro on my laptop

@wieslawsoltes
Copy link
Collaborator

wieslawsoltes commented Jul 28, 2023

@adamPetho Can you change following line:

<ScrollViewer HorizontalScrollBarVisibility="Auto" VerticalScrollBarVisibility="Disabled">

to:

<ScrollViewer HorizontalScrollBarVisibility="Auto" VerticalScrollBarVisibility="Auto">

and try repro?

@adamPetho
Copy link
Collaborator Author

@wieslawsoltes The change fixes my issue. 🎉

image

@wieslawsoltes
Copy link
Collaborator

@wieslawsoltes The change fixes my issue. 🎉

image

Well it's not really a fix, just show where issue is. I suspect it's some precision error in layout calculation.

@adamPetho

  1. Could you try if with [VDG] Update to Avalonia 11 #10423 to see if it has same issue ?

  2. Also could you try potential fix (workaround) [VDG] Fix missing wallet tile on small screen #11137 ?

@adamPetho
Copy link
Collaborator Author

adamPetho commented Jul 28, 2023

  1. Could you try if with [VDG] Update to Avalonia 11 #10423 to see if it has same issue ?

I can't run Wasabi with that branch right now.

2023-07-28 14:13:27.165 [1] CRITICAL    Program.Main (76)       System.InvalidOperationException: Could not create glyphTypeface.
   at Avalonia.Media.Typeface.get_GlyphTypeface()
   at Avalonia.Rendering.Composition.Compositor.get_DiagnosticTextRenderer()
   at Avalonia.Rendering.Composition.Compositor.CreateCompositionTarget(Func`1 surfaces)
   at Avalonia.Rendering.Composition.CompositingRenderer..ctor(IRenderRoot root, Compositor compositor, Func`1 surfaces)   at Avalonia.Controls.TopLevel..ctor(ITopLevelImpl impl, IAvaloniaDependencyResolver dependencyResolver)
   at Avalonia.Controls.WindowBase..ctor(IWindowBaseImpl impl, IAvaloniaDependencyResolver dependencyResolver)
   at Avalonia.Controls.WindowBase..ctor(IWindowBaseImpl impl)
   at Avalonia.Controls.Window..ctor(IWindowImpl impl)
   at Avalonia.Controls.Window..ctor()
   at WalletWasabi.Fluent.Views.MainWindow..ctor() in WalletWasabi.Fluent\Views\MainWindow.axaml.cs:line 11
   at WalletWasabi.Fluent.ApplicationStateManager.CreateAndShowMainWindow() in WalletWasabi.Fluent\ApplicationStateManager.cs:line 125
   at WalletWasabi.Fluent.State.StateMachine`2.StateContext.Enter() in WalletWasabi.Fluent\State\StateMachine.cs:line 226
   at WalletWasabi.Fluent.State.StateMachine`2.Enter() in WalletWasabi.Fluent\State\StateMachine.cs:line 108
   at WalletWasabi.Fluent.State.StateMachine`2.Goto(TState state, Boolean exit, Boolean enter) in WalletWasabi.Fluent\State\StateMachine.cs:line 133
   at WalletWasabi.Fluent.State.StateMachine`2.Enter() in WalletWasabi.Fluent\State\StateMachine.cs:line 112
   at WalletWasabi.Fluent.State.StateMachine`2.Start() in WalletWasabi.Fluent\State\StateMachine.cs:line 103
   at WalletWasabi.Fluent.ApplicationStateManager..ctor(IClassicDesktopStyleApplicationLifetime lifetime, UiContext uiContext, Boolean startInBg) in WalletWasabi.Fluent\ApplicationStateManager.cs:line 84
   at WalletWasabi.Fluent.App.OnFrameworkInitializationCompleted() in WalletWasabi.Fluent\App.axaml.cs:line 45
   at Avalonia.AppBuilder.SetupUnsafe()
   at Avalonia.AppBuilder.Setup()
   at Avalonia.AppBuilder.SetupWithLifetime(IApplicationLifetime lifetime)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode)
   at WalletWasabi.Fluent.Desktop.WasabiAppExtensions.<>c__DisplayClass0_0.<RunAsGuiAsync>b__0() in WalletWasabi.Fluent.Desktop\Program.cs:line 176
   at WalletWasabi.Daemon.WasabiApplication.RunAsync(Func`1 afterStarting) in WalletWasabi.Daemon\WasabiAppBuilder.cs:line 67
   at WalletWasabi.Fluent.Desktop.WasabiAppExtensions.RunAsGuiAsync(WasabiApplication app) in WalletWasabi.Fluent.Desktop\Program.cs:line 156
   at WalletWasabi.Fluent.Desktop.Program.Main(String[] args) in WalletWasabi.Fluent.Desktop\Program.cs:line 64
  1. Also could you try potential fix (workaround)

The workaround works and fixes the issue.

@wieslawsoltes
Copy link
Collaborator

The workaround works and fixes the issue.

@adamPetho ok let's go with workaround PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants