Support full-rbf

[lontivero]

Scope

Receive, recognize and process full-RBF replacement transactions.

Note: (Out of scope) touch anything related to sending transactions.

Wasabi Client

• Connect to nodes signaling full RBF #12641 This is required to receive the replacement transactions.

• Double spending tx are considered replacement #12301 Replace the tx if spending the same input.

Wasabi Backend

• Enable support for full-RBF in our backend Bitcoin Knots node #12642
• Consider using full RBF as DoS counter meassure #12643
• Continue planning after the tasks above are done. Organize full RBF 2 meeting.

[lontivero]

• Enable support for full-RBF in our backend Bitcoin Knots node #12642 knots settings were rollback to default values in testing. After a week or so we can do the same in production. This has to be done before deploying 👇
• Consider using full RBF as DoS counter meassure #12643 is implemented by Do not abort rounds paying more than attacker #12677

[kristapsk]

Should also enable full-RBF on Knots node bundled with Wasabi client (if it's not already enabled, there is some code for mempoolreplacement=, but probably it already defaults to Knots defaults, which is full-RBF, not sure by brief looking at code). https://github.com/zkSNACKs/WalletWasabi/blob/1d4c660b5f87e1d9f9c4039bc197209bcc1ba41e/WalletWasabi/BitcoinCore/CoreNode.cs

[molnard]

The current master deployed to TestNet. Can you enable full RBF on the node there @kristapsk ?

And we are planning to deploy to prod on Monday. We need to do the same there. Can that work?

[kristapsk]

The current master deployed to TestNet. Can you enable full RBF on the node there @kristapsk ?

It's already enabled. https://github.com/zkSNACKs/MaintenanceVault/issues/335#issuecomment-2004436777

[kristapsk]

Don't think this is resolved, there is still mempoolreplacement=fee,optin, which means no full-RBF for Knots, in bundled node with client.

[molnard]

Everything is done.