Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast notifications on WasabiWindow #845

Closed
molnard opened this issue Nov 14, 2018 · 7 comments
Closed

Toast notifications on WasabiWindow #845

molnard opened this issue Nov 14, 2018 · 7 comments

Comments

@molnard
Copy link
Contributor

molnard commented Nov 14, 2018

Temporary messages like:

  • Address copied to Clipboard
  • Transaction successfully sent
  • Error message, etc.

are now appearing among the controls of the Wallet UI. This could be replaced with toast notifications which is already used by different platforms. Usually these notifications are showed at the center bottom of the window and disappearing after a few seconds.

@nopara73
Copy link
Contributor

Concept ACK.

@lontivero
Copy link
Collaborator

I will be working on a proposal for this.

@lontivero
Copy link
Collaborator

Probably this is not 100% related to the ticket but I think it would be good to handle all the notifications, alerts, error messages in an uniform way. Currently we each functionality display messages in a different place.

We could add a notifications bar on top of the status bar and display errors and messages there. It doesn't use more UI space because i reduced the margins and spacing.

image

image

What do you think?

@nopara73
Copy link
Contributor

I think it's 100% related and it's a good idea. But with Toast Notifications implemented it makes no sense. Now the question is should we drop Toast Notifications plan in favor of this altogether or not? I would vote for Toast, but I can be convinced otherwise.

@danwalmsley @molnard @lontivero Make your vote.

image

@molnard
Copy link
Contributor Author

molnard commented Mar 19, 2019

I think it is good enough for now it look much better than the randomly placed texts. Also the code will be cleaner with this. If @lontivero implements this with a uniform interface than later we can change the graphical part to a better one.
I have some suggestions about the interface I hope you won't mind:

  1. There should be a individual Toast-service class which handles the toast-requests.
  2. There should be a list of toasts instead of immediately showing the current one. In that way every message will be displayed at least for a short time, meanwhile new ones can be added.
  3. There should be a Color and message property and also some defaults for warning error and info
  4. Animation (fading) of the toast should be handled by the service, so from "outside" the is only thing is required to call the ToastService.Show("Transacion good",ToastSeverity.Info)

@danwalmsley
Copy link

My vote is to have this until we get toast notifications (provided its not a lot of work)

Otherwise why not put the effort into toast notifications.

If we do this, we could make the ui a control that overlays and looks like a toast notification.

@nopara73
Copy link
Contributor

#2544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants