Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CodeFactor issues #10073

Merged
merged 4 commits into from Feb 8, 2023
Merged

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Feb 7, 2023

Fixes CF issues in CoinJoinManager.cs & CoinJoinStateViewModel.cs to address #10059 (comment)

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 7, 2023
@molnard
Copy link
Collaborator

molnard commented Feb 7, 2023

Did something happen with CF?

@yahiheb
Copy link
Collaborator Author

yahiheb commented Feb 7, 2023

Did something happen with CF?

CF has never been consistent, issues get introduced without CF warning about them, but then it warns about them when someone does changes in files completely unrelated, like what happened with #10059.

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WalletWasabi/WabiSabi/Client/CoinJoinManager.cs Outdated Show resolved Hide resolved
@yahiheb yahiheb requested a review from molnard February 7, 2023 05:05
@molnard molnard merged commit 22ae777 into zkSNACKs:master Feb 8, 2023
@yahiheb yahiheb deleted the codefactor-issues branch February 8, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants