New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config
: Merge load methods
#10077
Config
: Merge load methods
#10077
Conversation
public override void LoadOrCreateDefaultFile() | ||
/// <inheritdoc/> | ||
public override void LoadFile(bool createIfMissing = false) | ||
{ | ||
base.LoadOrCreateDefaultFile(); | ||
|
||
ServiceConfiguration = new ServiceConfiguration(GetBitcoinP2pEndPoint(), DustThreshold); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplication we want to get rid of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow-up to: #10045 (comment)
Review with whitespace off: https://github.com/zkSNACKs/WalletWasabi/pull/10077/files?diff=split&w=1