Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the impossible :) #10117

Merged
merged 3 commits into from Feb 16, 2023
Merged

Fix the impossible :) #10117

merged 3 commits into from Feb 16, 2023

Conversation

adamPetho
Copy link
Collaborator

Throw the exception to the outer try-catch block otherwise we can resurrect ended rounds.

Exmaple:

Round.SetPhase (90)	Round (34c600b6a1d8b3135ad7ef527c462c8d657951f37a3e7f6bacfcfc0ccde6d200): Phase changed: InputRegistration -> Ended
Round.SetPhase (90)	Round (34c600b6a1d8b3135ad7ef527c462c8d657951f37a3e7f6bacfcfc0ccde6d200): Phase changed: Ended -> ConnectionConfirmation
Arena.StepConnectionConfirmationPhaseAsync (194)	Round (34c600b6a1d8b3135ad7ef527c462c8d657951f37a3e7f6bacfcfc0ccde6d200): 2 alices removed because they didn't confirm.
Round.SetPhase (90)	Round (34c600b6a1d8b3135ad7ef527c462c8d657951f37a3e7f6bacfcfc0ccde6d200): Phase changed: ConnectionConfirmation -> OutputRegistration

adamPetho
adamPetho commented Feb 15, 2023
View reviewed changes
WalletWasabi/WabiSabi/Backend/Rounds/Arena.cs
CoinVerifier.VerifierAuditArchiver.LogException(round.Id, exc);
round.EndRound(EndRoundState.AbortedWithError);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set round.EndRound(EndRoundState.AbortedWithError); in the outer catch block.

molnard
molnard previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect the way it is.

Szpoti
Szpoti previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

molnard
molnard approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@molnard molnard merged commit 0a5f3a2 into zkSNACKs:master Feb 16, 2023
@adamPetho adamPetho deleted the fix_impossible branch February 20, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahiheb yahiheb yahiheb requested changes

@molnard molnard molnard approved these changes

@Szpoti Szpoti Szpoti left review comments

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamPetho @molnard @yahiheb @Szpoti