Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Renewal documentation #10124

Merged
merged 9 commits into from Mar 21, 2023
Merged

Improve Renewal documentation #10124

merged 9 commits into from Mar 21, 2023

Conversation

adamPetho
Copy link
Collaborator

No description provided.

WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
adamPetho and others added 2 commits February 27, 2023 12:12
Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
@adamPetho
Copy link
Collaborator Author

@kiminuo Thanks for the review. I will go over your suggestions once I'm sure that this is a valid certificate renewal process.

molnard and others added 4 commits March 17, 2023 15:49
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we were struggling because the win user must be the same where the CSR was generated and later decrypted. We should mention this important detail. Digicert tool is using the users public key to encrypt the file and only the same user can decrypt it after they send back the Certificate.

WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
WalletWasabi.Documentation/ClientDeployment.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this point, everyone has to use MY profile! Muhahaha

@molnard molnard merged commit 9180287 into zkSNACKs:master Mar 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants