Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] UI Decoupling #2 #10166

Merged
merged 4 commits into from Mar 1, 2023
Merged

[VDG] UI Decoupling #2 #10166

merged 4 commits into from Mar 1, 2023

Conversation

ichthus1604
Copy link
Collaborator

@ichthus1604 ichthus1604 mentioned this pull request Feb 22, 2023
Merged
SuperJMN
SuperJMN previously approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@SuperJMN SuperJMN left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record: this should go after #10165 is merged to master.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 27, 2023
nopara74
nopara74 previously approved these changes Feb 27, 2023
View reviewed changes
soosr
soosr reviewed Feb 28, 2023
View reviewed changes
WalletWasabi/Wallets/Wallet.cs Outdated Show resolved Hide resolved
WalletWasabi/Wallets/Wallet.cs Outdated Show resolved Hide resolved
@ichthus1604 ichthus1604 dismissed stale reviews from nopara74 and SuperJMN via ba3cf33 February 28, 2023 19:59
@pull-request-size pull-request-size bot added size/S and removed size/M labels Feb 28, 2023
soosr
soosr approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@soosr soosr merged commit d46b20e into zkSNACKs:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lontivero lontivero lontivero approved these changes

@SuperJMN SuperJMN SuperJMN approved these changes

@soosr soosr soosr approved these changes

@nopara74 nopara74 nopara74 left review comments

@wieslawsoltes wieslawsoltes Awaiting requested review from wieslawsoltes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ichthus1604 @lontivero @SuperJMN @soosr @nopara74