Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CTS to caller #10174

Merged
merged 6 commits into from Feb 23, 2023
Merged

Move CTS to caller #10174

merged 6 commits into from Feb 23, 2023

Conversation

adamPetho
Copy link
Collaborator

Addition to #10153

Full discussion here #10153 (comment)

So I tend to think that caller should specify how long it is willing to wait for a single response.

I totally agree with this.

@adamPetho
Copy link
Collaborator Author

AffiliateServerStatusUpdaterTests.GetStatusTestAsync fails on CI.

I did not touch it.

@kiminuo
Copy link
Collaborator

kiminuo commented Feb 23, 2023 •
edited

Concept ACK

AffiliateServerStatusUpdaterTests.GetStatusTestAsync fails on CI.

I did not touch it.

#10169

kiminuo
kiminuo approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@kiminuo kiminuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kiminuo kiminuo mentioned this pull request Feb 23, 2023
Merged
molnard
molnard approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@molnard molnard merged commit b9ec79b into zkSNACKs:master Feb 23, 2023
@adamPetho adamPetho mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@kiminuo kiminuo kiminuo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamPetho @kiminuo @molnard @yahiheb