[VDG] UI Decoupling #8 #10239
Merged
[VDG] UI Decoupling #8 #10239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
February 28, 2023 18:25
soosr
requested changes
Apr 3, 2023
Done. Please check now. |
soosr
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigationState.Instancesingleton.NavigationStatenow implementsINavigateMainViewModelcode that handles changes toNavigationStateand encapsulates that code inNavigationStateitself.RoutableViewModel.SetActive()method and moves logic toNavigationState.OnCurrentPageChanged()NavigationState.InstancebyUIContext.Navigation()UIContextwhereUIContext.Defaultwould yield a new instance every time it's calledThis PR is in a workable state. Yet, as per VDG agreement this should not be merged before the release.
@SuperJMN you can rebase your PRs for ViewModel refactors off of this one.
Next step of UI Decoupling series: introduce source-generated fluent navigation APIs. Will be addressed in a future PR.