New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG] Make error messages more user friendly #10344
Merged
soosr
merged 13 commits into
zkSNACKs:master
from
soosr:fix-9907-user-friendly-exceptions
Apr 3, 2023
Merged
[VDG] Make error messages more user friendly #10344
soosr
merged 13 commits into
zkSNACKs:master
from
soosr:fix-9907-user-friendly-exceptions
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopara73
previously approved these changes
Mar 29, 2023
wieslawsoltes
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
ToUserFriendlyString()
method to the UI side, as all the references were from the UI and this is more like a UI concept than a business.The idea is to slowly add more and more exceptions here and thus the error dialogs can give messages that are understandable for nontech guys.