Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBitcoinExtensions: Remove unused methods #10351

Merged
merged 2 commits into from Mar 23, 2023
Merged

NBitcoinExtensions: Remove unused methods #10351

merged 2 commits into from Mar 23, 2023

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Mar 23, 2023

I noticed this while working on #10010.

@kiminuo kiminuo marked this pull request as ready for review March 23, 2023 11:36
yahiheb
yahiheb approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@molnard molnard requested a review from soosr March 23, 2023 14:23
molnard
molnard approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If UI is not using that it is OK. It seems like they are using CurrencyExtensions.cs instead.

soosr
soosr approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lontivero lontivero merged commit 916ef7a into zkSNACKs:master Mar 23, 2023
5 checks passed
@kiminuo kiminuo deleted the feature/2023-03-23-remove-unused-methods branch March 23, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@turbolay turbolay turbolay approved these changes

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kiminuo @molnard @turbolay @soosr @yahiheb @lontivero