Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard text observables produce nullable values #10374

Merged
merged 1 commit into from Mar 29, 2023

Conversation

YohDeadfall
Copy link
Collaborator

As @soosr pointed out in #10318 (comment) null values are expected here.

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soosr soosr merged commit c7ca251 into zkSNACKs:master Mar 29, 2023
6 of 7 checks passed
@MaxHillebrand
Copy link
Member

Congrats on your first merged PR @YohDeadfall, hopefully the first of many! 🖤

@soosr
Copy link
Collaborator

soosr commented Mar 29, 2023

Congrats on your first merged PR @YohDeadfall, hopefully the first of many! 🖤

It is the second 😉 #10318

@YohDeadfall
Copy link
Collaborator Author

Thank you, but this is the second one already (:

@MaxHillebrand
Copy link
Member

MaxHillebrand commented Mar 29, 2023

You guys are shipping code faster than anyone can keep up...

98bae098b01aa660cf80c298e337e9d0--math-comics-math-cartoons.jpg

@YohDeadfall YohDeadfall deleted the fix-clipboard-text-nullability branch April 13, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants