Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract SelectCoinsForRound to CoinJoinCoinSelector static class #10403

Merged
merged 3 commits into from Mar 31, 2023
Merged

Extract SelectCoinsForRound to CoinJoinCoinSelector static class #10403

merged 3 commits into from Mar 31, 2023

Conversation

adamPetho
Copy link
Collaborator

@adamPetho adamPetho commented Mar 31, 2023 •
edited

Reduce the complexity of CoinJoinClient

@adamPetho adamPetho marked this pull request as ready for review March 31, 2023 10:30
@molnard
Copy link
Collaborator

molnard commented Mar 31, 2023

image

@molnard
Copy link
Collaborator

molnard commented Mar 31, 2023

image

CoinJoinClient improved however the moved code stayed the same as before - that is why CS is complaining. In general this is an improvement.

molnard
molnard approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, just moved the code. (and removed one unused)

@molnard molnard merged commit 16069ef into zkSNACKs:master Mar 31, 2023
5 of 7 checks passed
@adamPetho adamPetho mentioned this pull request Mar 31, 2023
Merged
@adamPetho adamPetho deleted the get_coinCandidates_by_func branch April 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamPetho @molnard