Fix typos #10444
Merged
Fix typos #10444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahiheb
commented
Apr 4, 2023
| @@ -33,7 +33,7 @@ public enum WabiSabiProtocolErrorCode | |||
| DeltaNotZero, | |||
| WrongNumberOfCreds, | |||
| CryptoException, | |||
| AliceAlreadySignalled, | |||
| AliceAlreadySignaled, | |||
There was a problem hiding this comment.
Is this change correct?
There was a problem hiding this comment.
So I think we serialize enums to numbers and as such the change would be safe. I think that @lontivero would know for sure because he has been working with JSON serializers a lot lately.
Another concern is that BTCPAY and Trezor might depend on this name but it should be a simple change on their side too.
So I'm not sure.
There was a problem hiding this comment.
I would be very hesitant about this change.
There was a problem hiding this comment.
Revert this, might breaks the compatibility.
|
LGTM apart that one comment. |
adamPetho
previously approved these changes
Apr 5, 2023
molnard
approved these changes
Apr 5, 2023
| @@ -33,7 +33,7 @@ public enum WabiSabiProtocolErrorCode | |||
| DeltaNotZero, | |||
| WrongNumberOfCreds, | |||
| CryptoException, | |||
| AliceAlreadySignalled, | |||
| AliceAlreadySignaled, | |||
There was a problem hiding this comment.
Revert this, might breaks the compatibility.
Reverted. |
molnard
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typos, adds some words to
exclusion.dicbe excluded from Spell Checker, and renames some variables.There are more typos that could be fixed but I would prefer to do that in follow up PRs.