Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] minor fixes #10449

Merged
merged 1 commit into from Apr 6, 2023
Merged

[website] minor fixes #10449

merged 1 commit into from Apr 6, 2023

Conversation

MarnixCroes
Copy link
Collaborator

No description provided.

@molnard
Copy link
Collaborator

molnard commented Apr 6, 2023

2 approvals required ✅

Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one comment, LGTM

@@ -153,13 +153,13 @@ <h1 class="text-center title-lined mb-5">FAQ</h1>
WHAT IS A “COINJOIN”?
</label>
<div class="card-content">
<p>Coinjoin is a collaborative transaction between multiple peers.</p>
<p>A coinjoin is a collaborative transaction between multiple peers.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this?

A coinjoin is a coll... IMO this has one more 'a' than necessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is, as here coinjoin is a noun (a coinjoin) and not a verb (to coinjoin)
ping expert @Belliusz

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs the definite article because Marnix is right. It's a noun and you're referring to the act of coinjoining. So "A coinjoin is a collaborative...." is the correct version of that sentence.

@molnard molnard merged commit 9332910 into zkSNACKs:master Apr 6, 2023
6 of 7 checks passed
@MarnixCroes MarnixCroes deleted the website branch April 6, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants