Use the TXID as the initial file name for PSBT

[adamPetho]

Fixes: #10513

From the top of my head I went with the first 5 character of the txid as the initial name for the PSBT file.

Feel free to suggest otherwise.

[MarnixCroes]

nice

[MaxHillebrand]

Super useful.
cACK

[kiminuo]

LGTM, not tested

[yahiheb]

This is how it looks now I guess it is too long 2dd31fbf6731d4dbf2b0a419a2d8cd83628a7f7d78998b3a5d81ded09cdff6c0.psbt.

[adamPetho]

This is how it looks now I guess it is too long 2dd31fbf6731d4dbf2b0a419a2d8cd83628a7f7d78998b3a5d81ded09cdff6c0.psbt.

There is nothing human-readable inside a psbt file.
So IMO it's a nice addition to have the whole TXID as its name.
User can easily check the status of the tx on a block explorer. (don't need to open Wasabi)

Also, as Kimi said:

the user is free to make it shorter

[kiminuo]

This is how it looks now I guess it is too long 2dd31fbf6731d4dbf2b0a419a2d8cd83628a7f7d78998b3a5d81ded09cdff6c0.psbt.

I opened a random block explorer. I can type there 9d3f7d892f702bdfbcc1f76ebd18fe5611d7b66cb799dc76be50e938371e8f3a and it works. If I query 9d3f7d892 (shorter name), it returns nothing.

Obviously, the question is whether this is what people do, but mostly if I have a transaction, I want to know what it is about so I use a tool to inspect it (block explorer, etc.) So to me it makes sense.

[molnard]

Can you test if CC can handle that size of filename on the SD card?

[adamPetho]

Can you test if CC can handle that size of filename on the SD card?

CC has no problem with the long file name.

I was able to sign the psbt with CC and broadcasted the signed psbt with Wasabi.

[yahiheb]

User can easily check the status of the tx on a block explorer. (don't need to open Wasabi)

I guess the main reason to use the PSBT workflow and save the PSBT file is to import it to a hardware wallet to sign it and then broadcast it.
So the user cannot check the transaction if they didn't even broadcast it yet.

Obviously, the question is whether this is what people do, but mostly if I have a transaction, I want to know what it is about so I use a tool to inspect it (block explorer, etc.) So to me it makes sense.

If what I said above is true then I doubt that people will be getting their txid from a file saved on an MicroSD card or something.

[MaxHillebrand]

Short identifier are fine, imo.

Is the full txid inside the file?

[adamPetho]

Is the full txid inside the file?

No, there is nothing human-readable inside the PSBT.

[kiminuo]

So the user cannot check the transaction if they didn't even broadcast it yet.

You can still check it after you broadcast it, or not? Hm, or does this change txid?

Btw: Can I download PSBT of wasabi transactions? I mean those that are not to be used in a hardware wallet.

[molnard]

TXID as filename - ACK

[brizik]

tACK
TXID set as the initial file name for PSBT (FYI - works with hard wallet ONLY)

[molnard]

tACK

[molnard]

Any objective reason to change this?

[yahiheb]

Any objective reason to change this?

No objections it is just unnecessarily a long file name.

[yahiheb]

So the user cannot check the transaction if they didn't even broadcast it yet.

You can still check it after you broadcast it, or not? Hm, or does this change txid?

AFAIK no it doesn't change the txid, and yes of course you can check it after you broadcast the tx, but honestly what is the likelihood that a user would copy the txid from that file stored on some MicroSD Card, that is very weird UX, you can simply copy the txid from the history list.

Btw: Can I download PSBT of wasabi transactions? I mean those that are not to be used in a hardware wallet.

No currently there is no way to that in Wasabi.