Fix CjManager Notification flow

[adamPetho]

Fixes: #10521

It got messed up in #10441

Previously:
We notified the MusicBox about the PlebStop, but right after that, we overwrote the MusicBox status and the user couldn't override the PlebStop.

With this:
User get to decide if he wants to override the PlebStop or not. Just as before my mistake.

Please test this PR and look out for edge cases.

[Szpoti]

tACK, one concern only

[turbolay]

CleanShot.2023-04-19.at.08.14.35.mp4

Before your changes this wasn't happening, user would directly face the PlebStop

[adamPetho]

CleanShot.2023-04-19.at.08.14.35.mp4
Before your changes this wasn't happening, user would directly face the PlebStop

Is this mandatory to fix? I have a solution for it, but it's far from optimal.

[turbolay]

Unfortunately, I would say yes, it is mandatory.
It introduces a bad flickering + is proof that something fishy is going on.

This logic is extremely tricky (to not say bad) and it would be best to ensure that it is untouched.

[yahiheb]

tACK, just a small suggestion to fix CI.

[turbolay]

Getting closer, but when I have only unconfirmed funds, I have the message Waiting for coinjoin when I should have Waiting for confirmed funds

[turbolay]

I am also stuck on Successful coinjoin! continuing.... if I can't immediately participate in a new round:

• In the video, it's because all my coins were made private (it should display Hurray!! All your coins are private)
• In the screenshot, because all my coins are pending (it should display Waiting for confirmed coins)

CleanShot.2023-04-19.at.18.35.28.mp4

[soosr]

I can't review this, removing myself.

[Szpoti]

I made a fix for this: Szpoti@3e8bb17
(forgot to remove the comment, trivial)
@adamPetho does it makes sense to you?
@turbolay can you verify it works for you as well?

[adamPetho]

I made a fix for this: Szpoti@3e8bb17 (forgot to remove the comment, trivial) @adamPetho does it makes sense to you?

Thanks Szpoti!

I think it makes sense.

[adamPetho]

I am also stuck on Successful coinjoin! continuing.... if I can't immediately participate in a new round

In the video, it's because all my coins were made private (it should display Hurray!! All your coins are private)
In the screenshot, because all my coins are pending (it should display Waiting for confirmed coins)

@turbolay Could you please re-test these scenarios with the latest commit?

[turbolay]

tACK

[yahiheb]

Tested. LGTM

[molnard]

tACK