[VDG] UI Decoupling #16 #10576
Merged
[VDG] UI Decoupling #16 #10576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 7, 2023 11:07
|
@SuperJMN @ichthus1604 Merging Receive 3 caused conflict here, please take a look. |
soosr
previously approved these changes
Jun 2, 2023
YohDeadfall
previously approved these changes
Jun 2, 2023
|
My comments above can be addressed in any follow up pull request, so this one won't be blocked from merging. |
YohDeadfall
reviewed
Jun 2, 2023
YohDeadfall
approved these changes
Jun 5, 2023
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavBarItemViewModelfrom the inheritance hierarchy ofDialogViewModelBase, and hence all ViewModels for dialogs in the entire software.INavBarToggleandINavBarButtoninterfaces, which enables the NavBar to interact with ViewModels that implement them, instead of relying on a common base type.WalletPageViewModelwhich controls the different states and screens shown for each wallet in the wallet list:Login->Loading->WalletViewModelRoutableViewModelandWalletViewModel.