New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show CJ broadcasted if wallet had no input in the round #10607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do it without adding business logic?
Naive ideas:
- Change the message in the music box to be correct?
- Just indicate failure in the UI?
- Any other idea that is not touching the business but fixing this edge case UI problem?
58a88d8
to
67091e6
Compare
67091e6
to
8f7b0de
Compare
b59f8e1
to
c889ee9
Compare
I followed your advice @molnard and now throws instead of the complexity I had before. |
Sorry, I did something wrong here with git. I've just synced with your branch and this happened. I don't know how to fix it, can you take a look - it might be easier to remove my last commit as you are the owner of the branch. |
d15e8aa
to
c889ee9
Compare
I removed your commit, I just resetted branch and forced push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Fixes #9544
The issue is that the round success, just we had no input in it because we lost internet before confirming inputs (so we didnt make the round to fail). Because the
ViewModel
is only checking if the round failed or succeed, it will display success.The solution is to check if we had any input in the round, and if no pass the information in the
RoundEnded
object.These are the minimum changes possible to fix the issue, if anyone has any idea please express it.
Really annoying to test, you have to close the lid (make computer to go to sleep) during last minute of
InputsRegPhase
then wait 5 minutes then pray for the round to be successful.