On shutdown prevention, stop the CJM to participate in new rounds. On cancel, restart them. #10664
Conversation
|
I think it should restart the CJ if we leave the dialog. I actually worked a bit on the feature this morning (not because it was easy, but because I thought it would), but it was not working so I didn't make a PR. |
Yepp |
adamPetho
changed the title
I updated the PR + the description. |
|
I'm blocked until this gets resovled #10657 (comment) |
|
The merge of #10671 unblocked this PR. It's ready for tests and reviews. |
|
@MarnixCroes could you please re-test both scenarios? Both should be fixed by my latest 2 commit. Ty. |
There was a problem hiding this comment.
@MarnixCroes could you please re-test both scenarios? Both should be fixed by my latest 2 commit. Ty.
|
Ty for the testing @MarnixCroes, I will check what's going on with this |
|
@MarnixCroes could you please re-test this PR with the latest commit? Thanks 💖 |
| async () => | ||
| { | ||
| await _coinJoinManager.RestartAbortedCoinjoinsAsync(); | ||
| Navigate().Clear(); |
There was a problem hiding this comment.
This is only good until somebody not touches CancelCommand.
Shouldn't be this more correct?
| Navigate().Clear(); | |
| CancelCommand.Execute(null); |
There was a problem hiding this comment.
I really don't know. I didn't see the usage of CancelCommand.Execute(null) in the codebase before, so I went with this.
Maybe @soosr knows more about this.
Fixes: #10653
This PR stops all wallets in
InputReg phaseon shutdown prevention.Also, it signals to the CJM not to participate in new rounds, once they are finished with the
Critical phase.If the user cancels the shutdown prevention (changed his mind about quitting), restart the CJs.
How to test:
input reg phaseare stopped/cancelled.Critical phasedon't participate in new rounds.You can also test the case when you cancel the shutdown prevention, the wallets that were in input reg are restarted.