Verify formatting in pipelines #10684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can add this, but GitHub action is easier and also the future. Can you try to do the same with GitHub Actions? |
|
Sure, I just thought that you use Azure for a very strong reason. |
|
There was but it seems like not a problem anymore since we already added actions and nobody complained. |
nopara73
suggested changes
May 16, 2023
YohDeadfall
force-pushed
the
check-formating
branch
from
c11e71b
to
edfd09d
Compare
|
@molnard, well, isn't this PR intending to improve code quality? So, in addition to the pipeline I fixed all formatting issues we had (mostly spaces and usings) and a few CA2000 warnings. If I did all of these changes and checked them using |
Closed
This was referenced May 17, 2023
Merged
Closed
|
Can you tell me why the formatting pipeline fails here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That pull requests adds formatting check to Azure pipelines, so reviewers won't spend their time on that task. Perhaps, it will require formatting the existing code, but maybe not.
Rules can be configured though
.editoconfig.