Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] UI Decoupling #22 #10716

Merged
merged 17 commits into from Jun 11, 2023
Merged

[VDG] UI Decoupling #22 #10716

merged 17 commits into from Jun 11, 2023

Conversation

ichthus1604
Copy link
Collaborator

  • Introduces IWalletSettingsModel which consolidates all wallet settings, including coinjoin settings, which were previously split among several ViewModels,
  • Decouples WalletSettingsViewModel and CoinjoinSettingsViewModel via the above abstraction

@ichthus1604 ichthus1604 mentioned this pull request May 18, 2023
Merged
@ichthus1604 ichthus1604 mentioned this pull request May 23, 2023
Open
@soosr
Copy link
Collaborator

soosr commented Jun 6, 2023

also CI is failing

soosr
soosr reviewed Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during wallet creation if you change anything on the coinjoin profile selection. It won't get saved. Because the values don't get into the keymanager.
Basically the changes should be stored in the keymanager, but KeyManager.ToFile() shouldn't be called

soosr
soosr approved these changes Jun 11, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit a9dd723 into zkSNACKs:master Jun 11, 2023
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ichthus1604 @soosr