New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure used keys are saved into a file. #10780
Conversation
@lontivero The solution here is dirty but the interface is not letting me touch the file directly. However, it is not worse than before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to make sure the keys' state are always persisted immediately then you should pass the this
keymanaget to this method:
https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi/Blockchain/Keys/KeyManager.cs#L503
I did not say always. I want to do that only here. |
The thing is that CoinJoinManager shouldn't even know about the persistence mechanism. The KeyManager is the one that should abstract all that. If the changes in the key state have to be persisted in all or some situations and that is not happening then it is the KeyManager that have to be improved and not the CoinJoinManager. |
@lontivero I tried my best. I think it is even better because any time we use |
In addition to this #10711.
Making sure to save the used keys state to file - right after the modification.