[Trivial] Fix whitespaces and formatting #10783
Conversation
|
Dear Contributor, Thank you for your work👍We have strict rules about code style/format changes. Please respect our policy. Feel free to reopen on the first Monday, Tuesday, and Wednesday of the month and we will be happy to review it. Thank you for your understanding 🙏 |
|
LGTM, once reopened |
| .FirstOrDefault(x => x.ConstantValue?.Equals(navigationArgument.Value.Value) ?? false); | ||
| var enumValue = navigationTargetEnum.GetMembers() | ||
| .OfType<IFieldSymbol>() | ||
| .FirstOrDefault(x => x.ConstantValue?.Equals(navigationArgument.Value.Value) == true); |
There was a problem hiding this comment.
This is imho the only non-trivial change. Looks correct to me. Maybe it's a matter of style what variant to use. I don't find the former variant bad though. I'm ~0 on this.
There was a problem hiding this comment.
This change fixed this deepsource issue:
https://app.deepsource.com/gh/zkSNACKs/WalletWasabi/run/1a16c1f8-899f-448b-8129-83f5d8f0e678/csharp/CS-R1118?listindex=0
There was a problem hiding this comment.
I see. Ok then.
Still that Deep source feels useless to me. I mean I can't remember seeing it recommend something really important as its name suggests. For other things we have initializers, that are run in MSVS and one can see them immediately (which is faster to fix and we don't waste time on fixing issues once deep source finds it)
Can be easily reviewed with whitespace changes off:
https://github.com/zkSNACKs/WalletWasabi/pull/10783/files?diff=unified&w=1