Remove unused SmartCoin.Secret
#10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something unrelated to this PR directly, what should be done with all these Deepsource warnings? |
|
Honestly, warnings from the DeepSource do not seem "deep" to me at all. Imho one can just turn on similar analyzers using |
No, this property is a leftover that is never. |
lontivero
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed this while reviewing #10790.
Questions
edit: Lucas mentioned in a Slack message: Context: that was used in WW1.x as a side channel to pass the key material to the coinjoin client (i don't remember the name of that thing). WW2.x never used it and then once you removed the client-side code for WW1.x that thing remained unsued.