Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Changed format of copied privacy balance #10863

Merged
merged 3 commits into from Jun 10, 2023
Merged

[VDG] Changed format of copied privacy balance #10863

merged 3 commits into from Jun 10, 2023

Conversation

YohDeadfall
Copy link
Collaborator

Fixes #10843.

@YohDeadfall YohDeadfall requested a review from soosr June 8, 2023 19:54
@YohDeadfall YohDeadfall changed the title Changed format of copied privacy balance [VDG] Changed format of copied privacy balance Jun 8, 2023
yahiheb
yahiheb previously approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@YohDeadfall
Copy link
Collaborator Author

Thanks, @yahiheb! Made bindings compiled in that view too and noticed a difference between the ring and the tile. There's a space displayed in the tile for the BTC amount, but it doesn't happen in the privacy ring. Should it be fixed?

@yahiheb
Copy link
Collaborator

yahiheb commented Jun 9, 2023

There's a space displayed in the tile for the BTC amount, but it doesn't happen in the privacy ring. Should it be fixed?

Personally I don't like the current format (with the space), but for consistency yes we should fix it since it is displayed everywhere with a space.
I guess the fix should be easy so it can be added in this PR.

@YohDeadfall YohDeadfall closed this Jun 9, 2023
@YohDeadfall YohDeadfall deleted the btc-copy-as-num branch June 9, 2023 13:31
@yahiheb
Copy link
Collaborator

yahiheb commented Jun 9, 2023

This PR was good.

@YohDeadfall YohDeadfall restored the btc-copy-as-num branch June 9, 2023 14:01
@YohDeadfall
Copy link
Collaborator Author

Ugh, closed it by an accident when did cleanup of branches. Resurrecting it.

@YohDeadfall YohDeadfall reopened this Jun 9, 2023
yahiheb
yahiheb approved these changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

soosr
soosr approved these changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit f1015a9 into zkSNACKs:master Jun 10, 2023
9 of 10 checks passed
@yahiheb yahiheb mentioned this pull request Jun 10, 2023
Merged
@YohDeadfall YohDeadfall deleted the btc-copy-as-num branch June 22, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolay turbolay turbolay approved these changes

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the space separator and the unit when copying/pasting the private balance
4 participants
@YohDeadfall @yahiheb @turbolay @soosr