Packager: Rename Daemon + Fix for Release mode
#10883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
changed the title
Release mode
yahiheb
approved these changes
Jun 13, 2023
kiminuo
commented
Jun 14, 2023
| <ItemGroup> | ||
| <ProjectReference Include="..\WalletWasabi\WalletWasabi.csproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
kiminuo
commented
Jun 14, 2023
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'"> | ||
| <OutputType>WinExe</OutputType> |
There was a problem hiding this comment.
WinExe is only for UI applications (eg WinForms or WPF). That's why in the Release mode the program did not wait for any console input.
|
@adamPetho can you please test it? |
kiminuo
commented
Jun 14, 2023
| @@ -25,6 +25,8 @@ namespace WalletWasabi.Packager; | |||
| public static class Program | |||
| { | |||
| public const string PfxPath = "C:\\digicert.pfx"; | |||
|
|
|||
| public const string DaemonExecutableName = Constants.DaemonExecutableName; | |||
There was a problem hiding this comment.
Done for consistency with the line below.
kiminuo
commented
Jun 14, 2023
| @@ -25,6 +25,8 @@ namespace WalletWasabi.Packager; | |||
| public static class Program | |||
| { | |||
| public const string PfxPath = "C:\\digicert.pfx"; | |||
|
|
|||
| public const string DaemonExecutableName = Constants.DaemonExecutableName; | |||
| public const string ExecutableName = Constants.ExecutableName; | |||
There was a problem hiding this comment.
I think it would be better to have:
Suggested change
| public const string ExecutableName = Constants.ExecutableName; | |
| public const string UiExecutableName = Constants.UiExecutableName; |
We can change it if you like.
adamPetho
approved these changes
Jun 14, 2023
|
Ok, it looks very safe to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
from https://github.com/orgs/zkSNACKs/projects/27/views/1
Testing
I'm not exactly why this leads to starting the Daemon process but not waiting for user input (pressing CTRL+C). I tried to addFixed by bc2a139.Console.Read()command but it did not help. Investigating. Maybe I'm doing something trivially wrong.Help is welcome.
edit: Testing the same on macOS works OK for me. So it's only on Win11 that
wassabeed.exedoes not wait for console input (on my machine at least).edit: edit: Fixed.