[easy] CoreNode: Fix warning #10891
Merged
[easy] CoreNode: Fix warning #10891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Jun 14, 2023
| } | ||
|
|
||
| public EndPoint P2pEndPoint { get; } | ||
| public EndPoint RpcEndPoint { get; } | ||
| public IRPCClient RpcClient { get; private set; } | ||
| public IRPCClient RpcClient { get; } |
There was a problem hiding this comment.
The property is required to be passed in the ctor effectively.
kiminuo
commented
Jun 14, 2023
| @@ -95,13 +96,13 @@ public static async Task<CoreNode> CreateAsync(CoreNodeParams coreNodeParams, Ca | |||
| throw new InvalidOperationException($"Failed to get RPC endpoint on {rpcHost}:{rpcPort}."); | |||
| } | |||
|
|
|||
| CoreNode coreNode = new(coreNodeParams.DataDir, coreNodeParams.Network, coreNodeParams.MempoolService, coreConfig, p2pEndPoint, rpcEndPoint); | |||
There was a problem hiding this comment.
Just moved under var rpcClient = new RPCClient( declaration.
adamPetho
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to run tests in #9695, I was debugging why they did not run for me. This PR just fixes a warning and arguably it's easier to understand the code.