New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG][Trivial] Simplify text of Preview Transaction dialog #10932
[VDG][Trivial] Simplify text of Preview Transaction dialog #10932
Conversation
@@ -45,13 +45,12 @@ | |||
|
|||
<!-- Address --> | |||
<c:PreviewItem Icon="{StaticResource transceive_regular}" | |||
Label="to the Bitcoin address" | |||
Label="address" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment but not a suggestion of changes for this PR, this field and the previous one (so receiver label + address) could be merged into one, it would declutter the screen and help for global understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me. It can be done in another PR.
WalletWasabi.Fluent/ViewModels/Wallets/Send/TransactionSummaryViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering why aren't the titles capitalized?
WalletWasabi.Fluent/Views/Wallets/Send/TransactionSummary.axaml
Outdated
Show resolved
Hide resolved
It looked a bit better like this, but at the end it was just a choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent confusion, I would make it clear that the fee gets added to the amount, not deducted/part of it
so additional fee
Where does this confusion come from? "A fee is the cost of something, or the amount of money charged." |
The Transaction Preview dialog (when sending) is full of text and not user friendly imo.
This is a small PR with minimal effort to simplify the text and make the dialog less cluttered.
Master:
PR: