Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurboSync: Add missing ConfigureAwaits #10946

Merged
merged 1 commit into from Jun 28, 2023

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Jun 27, 2023

Follow-up to #10896

Add missing ConfigureAwait(false) and allow tests to fail (and give us info about what failed rather than CI timeout after an hour if something goes wrong).

I reported some other issues in #10946.

@kiminuo kiminuo mentioned this pull request Jun 27, 2023
2 tasks
@kiminuo kiminuo changed the title TurboSync: Nits TurboSync: Add missing ConfigureAwaits Jun 28, 2023
@kiminuo kiminuo marked this pull request as ready for review June 28, 2023 06:57
@kiminuo kiminuo requested a review from turbolay June 28, 2023 06:57
Copy link
Collaborator

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Seems like a trivial PR

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, can merge.

@kiminuo kiminuo merged commit bb0aff2 into zkSNACKs:master Jun 28, 2023
8 of 9 checks passed
@kiminuo kiminuo deleted the feature/2023-06-27-Turbo-nits branch June 28, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants