[VDG] PrivacySuggestions: add warning for spending coinjoining coins #11055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxHillebrand
previously approved these changes
Jul 18, 2023
|
cACK. I am not sure if it needs to be a warning (Info instead?). Are there any privacy concerns about it? |
|
@soosr I used the warning as using coinjoining coins might cause issues, not necessarily for privacy pov. I can change it to info instead |
Info makes more sense, as they will still get the green shield in this case. |
turbolay
approved these changes
Jul 18, 2023
ichthus1604
requested changes
Jul 18, 2023
soosr
requested changes
Jul 19, 2023
WalletWasabi.Fluent/Models/Transactions/PrivacySuggestionsModel.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spending coinjoining coins causes issues for both client and backend, I think this warning makes a lot of sense.
Issue: similar to #11013, the suggestion doesn't get updated. So user can see the warning while coinjoin stopped in the meantime.