FilterProcessor: Remove lock
#11058
Merged
FilterProcessor: Remove lock
#11058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Jul 18, 2023
| @@ -17,67 +15,63 @@ public FilterProcessor(BitcoinStore bitcoinStore) | |||
| } | |||
|
|
|||
| private BitcoinStore BitcoinStore { get; } | |||
| private AsyncLock AsyncLock { get; } = new(); | |||
There was a problem hiding this comment.
ProcessAsync is called just from one place so the lock has no function at all at the moment.
|
The lock makes no sense. |
lontivero
approved these changes
Jul 18, 2023
kiminuo
deleted the
feature/2023-07-18-FiltersProcessor-remove-extra-lock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this during review of #11046. Given how complex that block filter processing is, I find it useful to remove unnecessary complexities.