[VDG] Add Confirmation Time to Transaction Details

[SuperJMN]

As the title says, this adds the estimated estimated confirmation time.

[yahiheb]

I don't see the confirmation time.

[SuperJMN]

@yahiheb @turbolay can you please check now? :)

[turbolay]

Better now, but there are still variations between the time displayed in the TX preview screen and this screen, which looks a bit weird. Also, I believe it doesn't handle CPFP etc...

[yahiheb]

There are two issues:

• The confirmation time is not the same on the Preview Transaction and on the Transaction Details. (As mentioned by turbolay)
• If the transaction gets confirmed while the Transaction Details dialog is open, the confirmation time section shouldn't be visible.

[SuperJMN]

• If the transaction gets confirmed while the Transaction Details dialog is open, the confirmation time section shouldn't be visible.

Should be fixed. Good catch!

[turbolay]

Everything seems to work fine for me, tACK

However, but this PR is not the place I believe:

• Why not display the FeeRate on this screen?
• Since we are shipping a release including CPFP, we should handle CPFP in this calculation. I believe that's especially important for TransactionPreviewScreen
• When we send a TX with custom FeeRate, we are not displaying anything in the TransactionPreviewScreen (Display the expected confirmation time on the Preview Transaction when a custom fee rate is used #11008), but we display something in the TransactionDetails which make absolutely no sense at all.

[ichthus1604]

utACK.

Code is okay.

Cannot test right now since TestNet wallets are working erratically.

[yahiheb]

The confirmation time is still not the same on the Preview Transaction and on the Transaction Details, sometimes with big difference sometimes just a bit.

Maybe the issue is with the Preview Transaction's confirmation time and not this PR.

[nopara73]

If it takes hours, don't show minutes. If it takes days, don't show hours. If it takes weeks, don't show days, and so on...

Otherwise, we allude accuracy to the user that we don't have. Furthermore, even if we could accurately predict, the user still would not need to be bothered by such noise.

[yahiheb]

Regardless of displaying the minutes, hours, days or not which should be done in a separate PR, the issue here is why do we get different results for the supposedly the same thing? We should get the same result.

[soosr]

I can reproduce @yahiheb's issue, and the source of the problem is the FeeRate calculation.
During sending I chose 8.413 sat/vbyte and the transaction was created with 8.444 sat/vbyte, while the transaction details received 12.x sat/vbyte

The transaction: https://mempool.space/testnet/tx/a884f63cd6d1726131da60049ff87bb9e97c4dc5312d3fb1a114ddc953ddba74

It works well with selfspend btw.

[SuperJMN]

I still don't see how the calculation can be wrong. I'm just using the Fee and VirtualSize to calculate the FeeRate:

        public FeeRate? FeeRate
	{
		get
		{
			if (Fee is null)
			{
				return null;
			}

			return new FeeRate(Fee, VirtualSize);
		}
	}

I'm lost. Can someone drop me a helping hand? cc @zkSNACKs/code-team

[turbolay]

The issue is rare and not caused by this PR.
I could only reproduce it when sending 1 coin from the same address to the same address, such as this TX:
https://mempool.space/testnet/tx/c09935ccb09b3aa17d73badec223e1cca390e182f392824f2d25103b3fcab0a8

I don't have the time right now to investigate more, but the issue is that containingTransaction.Transaction.GetVirtualSize() gives me a VSize of 82 when it should be 110 according to mempool.space (and I assume to the TransactionBuilder as well, but I didn't verify)

Everything seems to work well with this PR by itself, except the CPFP as I already mentioned.
Another thing to note, I assume that the Update Reactive command misses Skip(1) for the TransactionDetails because when I open the window everything is always called twice.

[yahiheb]

https://mempool.space/testnet/tx/30fe22c646eeae7b500652736566a16faadcb91254589a2bc940eb9d20bf296a
The fee rate used: 1.82 sat/vB

[soosr]

https://mempool.space/testnet/tx/30fe22c646eeae7b500652736566a16faadcb91254589a2bc940eb9d20bf296a The fee rate used: 1.82 sat/vB

Could you debug what is the fee rate that the transaction details received?

[nopara73]

FTR, I don't know how exactly you guys are estimating the fees, but the fee estimator that you're using only gives you a single entry back:

https://wasabiwallet.co/api/v4/btc/Blockchain/all-fees?estimateSmartFeeMode=CONSERVATIVE

This means 1 s/b should confirm within 20 minutes. So it's strange that 1.8 s/b gives you 3 and 8 hours.

[soosr]

On TestNet it uses hardcoded values

WalletWasabi/WalletWasabi.Fluent/Helpers/TransactionFeeHelper.cs

Lines 14 to 26 in 1fb06ef

	private static readonly Dictionary<int, int> TestNetFeeEstimates = new()
	{
	[1] = 17,
	[2] = 12,
	[3] = 9,
	[6] = 9,
	[18] = 2,
	[36] = 2,
	[72] = 2,
	[144] = 2,
	[432] = 1,
	[1008] = 1
	};

[yahiheb]

Could you debug what is the fee rate that the transaction details received?

It received 2.426 Sat/B while it is 1.82 sat/vB on https://mempool.space/testnet/tx/320bc22297f905498834857c89880319dea1f3d6c0c6e560d988ad62e01d8c5f

[nopara73]

AllFeeEstimate now has unit tested fee estimations:

public TimeSpan EstimateConfirmationTime(FeeRate feeRate)
public bool TryEstimateConfirmationTime(SmartTransaction tx, [NotNullWhen(true)] out TimeSpan? confirmationTime)

@SuperJMN @soosr please use this

[SuperJMN]

AllFeeEstimate now has unit tested fee estimations:

public TimeSpan EstimateConfirmationTime(FeeRate feeRate) public bool TryEstimateConfirmationTime(SmartTransaction tx, [NotNullWhen(true)] out TimeSpan? confirmationTime)

@SuperJMN @soosr please use this

@nopara73 please check what I did. I played by ear there.
I've tested it briefly and confirmation times seem coherent.

[yahiheb]

Now the confirmation time is the same, but the time on the fee chart is wrong.

Notice that the fee rate that the Preview Transaction/Details received is 2.426 Sat/B while it is 1.82 sat/vB on mempool.space.
As Turbolay mentioned in his comment:

the issue is that containingTransaction.Transaction.GetVirtualSize() gives me a VSize of 82 when it should be 110 according to mempool.space

What is this VirtualSize 82 compared to 110 vB? and what is 2.426 Sat/B compared to 1.82 sat/vB (different units)?

[nopara73]

As promised. Merging. Remaining issues:

• fee selection chart != conf time (I mean, they are the same, it's just the former is more refined.)
• conf time visibility update doesn't happen when tx details is open (@SuperJMN it should be easy to fix for you, if you have time, please do it)

<!-- Confirmation Time -->
      <c:PreviewItem IsVisible="{Binding IsConfirmationTimeVisible}"
                     Icon="{StaticResource timer_regular}"
                     Label="Confirmation time"
                     CopyableContent="{Binding ConfirmationTime}">
        <c:PrivacyContentControl>
          <TextBlock Text="{Binding ConfirmationTime, Converter={x:Static conv:TimeSpanConverter.ToEstimatedConfirmationTime}}" Classes="monoSpaced" />
        </c:PrivacyContentControl>
      </c:PreviewItem>

      <Separator IsVisible="{Binding IsConfirmationTimeVisible}" />

[SuperJMN]

• conf time visibility update doesn't happen when tx details is open (@SuperJMN it should be easy to fix for you, if you have time, please do it)

Fixed in #11116