Hardcode delay before signing #11169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molnard
requested changes
Aug 15, 2023
molnard
requested changes
Aug 15, 2023
lontivero
changed the title
kiminuo
reviewed
Aug 16, 2023
kiminuo
reviewed
Aug 16, 2023
There was a problem hiding this comment.
So I understand that if
RoundParameters.DelayTransactionSigning = falsethen we start transaction signing immediately and the signing period is 1 minute.RoundParameters.DelayTransactionSigning = truethen we start transaction signing 50 seconds later and the singing period is 50 seconds longer (so 1m50s in total)
Is that true?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #11141 consisting on 2 hardcoded delay values (0 seconds and 50 seconds).