Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Fee Chart - fix mid value #11213

Merged
merged 2 commits into from Aug 7, 2023
Merged

[VDG] Fee Chart - fix mid value #11213

merged 2 commits into from Aug 7, 2023

Conversation

soosr
Copy link
Collaborator

@soosr soosr commented Aug 4, 2023

Potentially fixes #11206

@soosr soosr mentioned this pull request Aug 4, 2023
Closed
MarnixCroes
MarnixCroes suggested changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on testnet it resulted in this

Screenshot from 2023-08-04 15-53-01
while on master it was 1,6,12

on mainnet it resulted in this

image

while on master something like 6,12,25

@soosr
Copy link
Collaborator Author

soosr commented Aug 4, 2023

@MarnixCroes

Opss, missing parenthesis... Fixed please try again.

MarnixCroes
MarnixCroes approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot repro the original issue right now, as it seems related to specific estimations.
Other than that, everything works fine
so t(rust)ACK

@soosr soosr merged commit b1414a9 into zkSNACKs:master Aug 7, 2023
7 checks passed
@MarnixCroes
Copy link
Collaborator

FWIW, can confirm this works:
this was this morning without the commit

Screencast.from.07-08-2023.12.13.51.webm

and with this commit (latest master) the chart was 7, 6 ,6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fee slider graph: bottom fee rate value higher than middle one
2 participants
@soosr @MarnixCroes