Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wrong usage of containingTx by spendingTx #11232

Merged
merged 1 commit into from Aug 8, 2023

Conversation

turbolay
Copy link
Collaborator

@turbolay turbolay commented Aug 7, 2023

This problem was encountered by @SuperJMN

@MarnixCroes can you please try to repro #11079 on this branch?
I'm not 100% sure that it fixes the issue, but it def looks like a mistake.

EDIT:
Fixes #11079

Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e83df09
disappeared addresses are back

giphy_okLCopqw6ElCDnIhuS_fixed_width

@turbolay turbolay requested a review from SuperJMN August 7, 2023 17:29
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nopara73 nopara73 merged commit 9d2b99d into zkSNACKs:master Aug 8, 2023
7 checks passed
@turbolay turbolay deleted the fixDestinationAddressDisappear branch February 26, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TX Details: Destination Address sometimes missing/disappearing
4 participants