Rename HttpClientFactory to WasabiHttpClientFactory and introduce CreateLongLivedHttpClient helper
#11307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lontivero @molnard concept ACK? |
adamPetho
approved these changes
Aug 17, 2023
|
cack |
kiminuo
commented
Aug 17, 2023
| /// <remarks>Created HTTP client handles correctly DNS changes.</remarks> | ||
| /// <seealso href="https://learn.microsoft.com/en-us/dotnet/core/extensions/httpclient-factory"/> | ||
| [SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", Justification = "HTTP client will dispose the handler correctly.")] | ||
| public static HttpClient CreateLongLivedHttpClient(TimeSpan? pooledConnectionLifetime = null, DecompressionMethods? automaticDecompression = null) |
There was a problem hiding this comment.
The method can be even in a different class. I have experimented with this but I can't seem to find a nicer/better name.
molnard
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
ACK. Basically no change here in behavior. Except that pooledConnectionLifetime by default was InfiniteTimeSpan?
Now it is 5 minutes, right?
|
The PR is designed as just refactoring. There should be no change in behavior. We had that 5-minute timeout here: https://github.com/zkSNACKs/WalletWasabi/pull/11307/files#diff-a0fad88b3a26fafa04bbd69a412b28ad930c02cbed0ae3b83026da06122006baL26. But we can also align with .NET where the timeout is 2 minutes (if I remember correctly). |
lontivero
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10569
Notes:
HttpClientFactoryis renamed toWasabiHttpClientFactoryto avoid confusion withIHttpClientFactoryin .NET.WasabiHttpClientFactory.CreateLongLivedHttpClientallows to createHttpClientinstances that can live for long-time (as DNS is properly updated).Globalwas done to use the newWasabiHttpClientFactory.CreateLongLivedHttpClienthelper method.Review is easy commit by commit. Each commit can be a standalone PR basically if needed.