Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Tor 0.4.8.5 #11501

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Upgrade to Tor 0.4.8.5 #11501

merged 4 commits into from
Sep 19, 2023

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Sep 15, 2023 •
edited

Changelog: https://gitlab.torproject.org/tpo/core/tor/-/blob/tor-0.4.8.5/ReleaseNotes:
Related to #10833

This PR upgrades Tor version from 0.4.7.13 to 0.4.8.5 to test the new conflux feature and if it has any impact on round disruptions.

Changelog

Changelog mentions:

Finally, this is the very first stable release of the 0.4.8.x series making,
among other features, Proof-of-Work (prop#327) and Conflux (prop#329)
available to the entire network. Several new features and a lot of bugfixes
detailed below.

[..]
o Major features (conflux):
- Implement Proposal 329 (conflux traffic splitting). Conflux splits
traffic across two circuits to Exits that support the protocol. These
circuits are pre-built only, which means that if the pre- built conflux
pool runs out, regular circuits will then be used. When using conflux
circuit pairs, clients choose the lower-latency circuit to send data to
the Exit. When the Exit sends data to the client, it maximizes
throughput, by fully utilizing both circuits in a multiplexed fashion.
Alternatively, clients can request that the Exit optimize for latency
when transmitting to them, by setting the torrc option 'ConfluxClientUX
latency'. Onion services are not currently supported, but will be in
arti. Many other future optimizations will also be possible using this
protocol. Closes ticket 40593.

Resources

Older upgrades:

@kiminuo kiminuo force-pushed the feature/2023-09-15-Upgrade-Tor-to-0.4.8.5 branch 3 times, most recently from f1a4930 to ccb3cc2 Compare September 16, 2023 06:34
@kiminuo kiminuo force-pushed the feature/2023-09-15-Upgrade-Tor-to-0.4.8.5 branch from b5966cf to 99555e2 Compare September 16, 2023 07:14
@kiminuo kiminuo marked this pull request as ready for review September 17, 2023 18:51
@adamPetho
Copy link
Collaborator

How to test this? Run Wasabi and see if it works?

@kiminuo
Copy link
Collaborator Author

kiminuo commented Sep 18, 2023

Yes. Ideally, try to coinjoin.

kristapsk
kristapsk reviewed Sep 18, 2023
View reviewed changes
WalletWasabi/Microservices/Binaries/README.md
@@ -7,7 +7,7 @@
`git update-index --chmod=+x bitcoind`
`git update-index --chmod=+x .\lin64\Tor\tor`
`git update-index --chmod=+x .\win64\Tor\tor.exe`
`git update-index --chmod=+x .\osx64\Tor\tor.real`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change about? Changed filename because of Tor Browser release vs Tor release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tor.real file. It's called tor in the latest release. Presumably they unified it.

@adamPetho
Copy link
Collaborator

adamPetho commented Sep 18, 2023 •
edited

Is it only me or can you guys find a CJ round with this PR on Mainnet? For me, the client can't find any rounds. Seems like the backend is not even responding to me.

There is no issue like this on TestNet.

EDIT: Today it just works well. One time issue was probably on my side.

@turbolay
Copy link
Collaborator

Is it only me or can you guys find a CJ round with this PR on Mainnet? For me, the client can't find any rounds. Seems like the backend is not even responding to me.

What is your problem exactly?
On Main, there are almost no inputs in the pool because we have lot of CJs unconfirmed (as usual when fee spikes), therefore many rounds are failing with AbortedNotEnoughAlices. Maybe it's what you're witnessing. Maybe it's also some temporary issues with SSL Certificate.

Because I tested this PR and had no issue.

turbolay
turbolay approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK on MacOS

yahiheb
yahiheb approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested coinjoining, LGTM.

@kiminuo
Copy link
Collaborator Author

kiminuo commented Sep 19, 2023

@kristapsk Could you test as well please? Then we would have all OSs covered.

adamPetho
adamPetho approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind my previous comment. Today it just works perfectly well.
I will quickly test this on Linux also.

MarnixCroes
MarnixCroes approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack 99555e2 deb 11

@kiminuo kiminuo merged commit e7a3d66 into WalletWasabi:master Sep 19, 2023
7 checks passed
@kiminuo kiminuo deleted the feature/2023-09-15-Upgrade-Tor-to-0.4.8.5 branch September 19, 2023 10:39
@molnard
Copy link
Collaborator

molnard commented Sep 19, 2023

Wow, GJ.

adamPetho pushed a commit that referenced this pull request Nov 28, 2023
@kiminuo @adamPetho
Upgrade to Tor 0.4.8.5 (#11501)
d19e877 
* Upgrade to the latest Tor
* macOS seems to distribute `tor` binary instead of `tor.real` binary
* Fix hashes
* Make sure that `tor` file is treated as binary file

(cherry picked from commit e7a3d66)
adamPetho added a commit that referenced this pull request Nov 28, 2023
@adamPetho
Revert "Upgrade to Tor 0.4.8.5 (#11501)"
37c4683 
This reverts commit d19e877.
@kristapsk kristapsk mentioned this pull request Feb 2, 2024
Closed
@kiminuo kiminuo mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapsk kristapsk kristapsk left review comments

@turbolay turbolay turbolay approved these changes

@adamPetho adamPetho adamPetho approved these changes

@yahiheb yahiheb yahiheb approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kiminuo @adamPetho @turbolay @molnard @kristapsk @yahiheb @MarnixCroes