Fix coinjoins shared overhead calculation #11635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lontivero
force-pushed
the
fix-coinjoins-shared-overhead-calculation
branch
from
fbb3503
to
e241b7f
Compare
|
This PR doesn't fix the problem but it should make it easier to understand the calculation and work on the real issue. |
kiminuo
reviewed
Oct 13, 2023
WalletWasabi/WabiSabi/Models/MultipartyTransaction/MultipartyTransactionParameters.cs
Outdated
Show resolved
Hide resolved
kiminuo
previously approved these changes
Oct 13, 2023
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
kiminuo
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On testnet, when the size of the coinjoin transaction is small, the weight of the transaction shared overhead is greater and can fall below the minimum transaction relay, failing to broadcast it.
The current shared overhead assumes the number of inputs and outputs is greater than 254, what is false in testnet in most of the cases. This is why this problem is important for
TestNetonly.