Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed string format to 1 number after dot. #11977

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

AlexisKv
Copy link
Contributor

Close #11972
Found sat/vByte Fee rate only in Transaction Details page.

Before:
image
After:
image

Anything under .05 will round down, and .05 and above will round up.

Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 2fde211 into WalletWasabi:master Nov 22, 2023
7 checks passed
@kristapsk
Copy link
Collaborator

I don't think this is correct. Feerates should be always rounded downwards, so 12.084 should become 12.0, not 12.1.

@MarnixCroes
Copy link
Collaborator

I don't think this is correct. Feerates should be always rounded downwards, so 12.084 should become 12.0, not 12.1.

fair point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Display Fee rate with only one decimal point
5 participants