Make sure we all use the same C# lang version #12006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we put this in https://github.com/zkSNACKs/WalletWasabi/blob/master/Directory.Build.props#L3 ? And maybe unify the: |
|
@wieslawsoltes I did this in https://github.com/zkSNACKs/WalletWasabi/pull/11897/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR5 (not merged yet, still waiting for the nix package). |
kiminuo
approved these changes
Nov 29, 2023
I don't know, can we? From my side this PR is satisfactory, it solves my problem. |
molnard
changed the title
yahiheb
approved these changes
Nov 29, 2023
|
Concept ACK |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently my VS auto-updated and I got the new C# - especially the new C# lang version => 12. After this VS started to offer new expressions that are only available in 12. I thought it was OK because we specified versions in config files precisely. Unfortunately, this was not the case with the lang version - other devs were not able to compile the project.
I propose to set the version of the lang from
latestto11to make this deterministic. In this case, automatic updates cannot mess up our code integrity. We have a similar concept with the .NET version as well - it is specified precisely.