Further memory leak fixes #1212

danwalmsley · 2019-03-07T19:37:06Z

Closes #1001
Closes #1094

Removed use of IDisposable in viewmodels, this is not really the correct way to handle this.

Added support in Shell for detecting when a Tab is opened

Initialise and deinitialise coinlist stuff when tab is opened and closed (freeing the memory).

nopara73 · 2019-03-07T23:40:09Z

memory grows while clikcing on ordering
closing and reopening tabs don't seem to grew memory

What else were the issues?

molnard

I tested it on MAC. No memory leaks when reopening tabs. Regarding ordering the memory increase until 600 Mb then it stops. Looks good

lontivero · 2019-03-09T19:28:33Z

Just a comment for clarification:

memory grows while clikcing on ordering: this was fixed or at least I don't see it happening now.
closing and reopening tabs don't seem to grew memory: this still happens but the current behavior is much better than before.

lontivero · 2019-03-09T19:32:49Z

I didn't see the @molnard's comment because we both commented at the same time.

600 Mb then it stops.

I can confirm this. In my cases it stops after 780MB or so.

closing and reopening tabs don't seem to grew memory

It does in my Linux. However it stops eating memory and goes back after GC pass.

Looks good to me too.

…model

…ill allow for performance increase later.

molnard · 2019-03-19T15:54:18Z

The same errors for me on win10x64. One more thing to add: if you send and get the invalid thread exc then go into receive and generate a new receive address you will get:

System.ArgumentException
  HResult=0x80070057
  Message=An item with the same key has already been added. Key: [0, Avalonia.Controls.Generators.ItemContainerInfo]
  Source=System.Collections
  StackTrace:
   at System.Collections.Generic.TreeSet`1.AddIfNotPresent(T item)
   at System.Collections.Generic.SortedDictionary`2.Add(TKey key, TValue value)
   at Avalonia.Controls.Generators.ItemContainerGenerator.Materialize(Int32 index, Object item, IMemberSelector selector)
   at Avalonia.Controls.Presenters.ItemVirtualizerNone.AddContainers(Int32 index, IEnumerable items)
   at Avalonia.Controls.Presenters.ItemVirtualizerNone.ItemsChanged(IEnumerable items, NotifyCollectionChangedEventArgs e)
   at Avalonia.Reactive.LightweightObservableBase`1.PublishNext(T value)
   at Avalonia.Utilities.WeakSubscriptionManager.Subscription`1.OnEvent(Object sender, T eventArgs)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedAction action, Object item, Int32 index)
   at System.Collections.ObjectModel.ObservableCollection`1.InsertItem(Int32 index, T item)
   at WalletWasabi.Gui.Controls.WalletExplorer.ReceiveTabViewModel.<.ctor>b__17_13() in C:\WORK\WalletWasabi\WalletWasabi.Gui\Controls\WalletExplorer\ReceiveTabViewModel.cs:line 71

danwalmsley · 2019-03-19T19:41:14Z

@lontivero I took out the sorting headers because they trigger a bug in avalonia which I need to have fixed to stop memory leak.

danwalmsley · 2019-03-19T19:41:25Z

Will fix the threading issues

molnard · 2019-03-21T19:37:17Z

@lontivero I took out the sorting headers because they trigger a bug in avalonia which I need to have fixed to stop memory leak.

is this the next step?

danwalmsley · 2019-03-21T23:41:20Z

@lontivero I took out the sorting headers because they trigger a bug in avalonia which I need to have fixed to stop memory leak.

is this the next step?

That's been worked on in avalonia, did you verify if my fix solved the issue with send tab?

molnard · 2019-03-22T11:07:13Z

@lontivero I took out the sorting headers because they trigger a bug in avalonia which I need to have fixed to stop memory leak.
is this the next step?

That's been worked on in avalonia, did you verify if my fix solved the issue with send tab?

yes it is OK now

molnard

Looks good Tab open/close memleak gone!

WalletWasabi.Gui/Tabs/WalletManager/GenerateWalletSuccessViewModel.cs

WalletWasabi.Gui/Controls/WalletExplorer/WalletInfoViewModel.cs

Merge master into memory-leaks

WalletWasabi.Gui/MainWindow.xaml.cs

WalletWasabi.Gui/Controls/WalletExplorer/CoinJoinTabViewModel.cs

WalletWasabi.Gui/Controls/WalletExplorer/CoinListViewModel.cs

WalletWasabi.Gui/Controls/WalletExplorer/SendTabViewModel.cs

WalletWasabi.Gui/Controls/WalletExplorer/WalletViewModel.cs

molnard · 2019-03-25T12:20:47Z

WalletWasabi.Gui/Dialogs/CannotCloseDialogViewModel.cs

 			OperationMessage = "Dequeuing coins...Please wait";
 			var canCancel = this.WhenAnyValue(x => x.IsBusy);
 			var canOk = this.WhenAnyValue(x => x.IsBusy, (isbusy) => !isbusy);

-			CancelTokenSource = new CancellationTokenSource().DisposeWith(Disposables);
+			CancelTokenSource = new CancellationTokenSource();


Should be disposed!

molnard · 2019-03-25T12:59:41Z

WalletWasabi.Gui/Controls/WalletExplorer/HistoryTabViewModel.cs

-#pragma warning restore CS4014 // Because this call is not awaited, execution of the current method continues before the call is completed
-				}).DisposeWith(Disposables);
+				.Subscribe(async _ => await RewriteTableAsync())
+				.DisposeWith(_disposables);

 			this.WhenAnyValue(x => x.SelectedTransaction).Subscribe(transaction =>


Also defined in the constructor. Remove this or that.

Is this still there?

molnard · 2019-03-25T13:40:53Z

WalletWasabi.Gui/Controls/WalletExplorer/TransactionViewModel.cs

 			_model = model;
 			ClipboardNotificationVisible = false;
 			ClipboardNotificationOpacity = 0;

-			_confirmed = model.WhenAnyValue(x => x.Confirmed).ToProperty(this, x => x.Confirmed, model.Confirmed).DisposeWith(Disposables);
-
+			//TODO: this should be disposed! Memory leak!
 			Global.UiConfig.WhenAnyValue(x => x.LurkingWifeMode).Subscribe(x =>


This should be disposed! Memory leak!

fix memleak on walletinfotab

molnard · 2019-03-25T20:47:37Z

@nopara73 it is ready to merge

fixes: #1001

Dan Walmsley added 3 commits March 7, 2019 18:16

Merge branch 'master' into fixes/memory-leaks

113db34

clear most of IDisposable infection from ViewModels

3146e83

remove further disposable stuff

2769900

nopara73 requested a review from molnard March 8, 2019 15:16

molnard approved these changes Mar 9, 2019

View reviewed changes

lontivero mentioned this pull request Mar 14, 2019

Lower CPU usage and Dispose UI stuff properly #1058

Closed

Dan Walmsley added 20 commits March 17, 2019 12:47

Merge remote-tracking branch 'origin/master' into fixes/memory-leaks

f079b75

remove IDisposable stuff from viewmodels.

96f27df

more idisposable stuff removed.

ce837d4

correct disposal on SendTabViewModel

ff9db66

fix some memory leaks with interaction between coinlist and coinview …

9aec94e

…model

polish and resolve statusbarviewmodel subscriptions.

b71a303

remove last remnants of idisposable (usings)

6e27af8

shell update

c42847b

code factor issues.

4ef1369

code factor

47b937b

careful refactoring of coinviewmodel for use property helpers which w…

dd4e614

…ill allow for performance increase later.

simplify coinviewmodel and polish code.

61b4430

fix memory issues with coinlistviewmodel and polish code.

a4db9c2

polish and tidy sendtabviewmodel

95f0dc0

fix memory leaks in history tab.

23c4db1

add accidentally removed code back to history tab.

461d6e3

coin join tab memory issues dealt with + code polish

b240039

code polish

bd65d79

receive tab open close handled.

efee8d7

coinjoin events observed on ui thread.

b22953f

Dan Walmsley added 2 commits March 20, 2019 23:46

fix call from invalid thread.

987bdf3

fix removing spent coins from the list.

096737b

Dan Walmsley added 3 commits March 22, 2019 20:02

re-enable sorting list.

ab56b15

coding standards.

4e34815

restore tabs on historytabview.

20885fc

danwalmsley marked this pull request as ready for review March 23, 2019 10:30

molnard approved these changes Mar 23, 2019

View reviewed changes

Use await

cf76618

nopara73 reviewed Mar 25, 2019

View reviewed changes

WalletWasabi.Gui/Tabs/WalletManager/GenerateWalletSuccessViewModel.cs Show resolved Hide resolved

nopara73 reviewed Mar 25, 2019

View reviewed changes

WalletWasabi.Gui/Controls/WalletExplorer/WalletInfoViewModel.cs Outdated Show resolved Hide resolved

nopara73 and others added 3 commits March 25, 2019 11:13

Fix Dispose pattern

7aad01d

git merge master

76d2514

Merge pull request #1 from molnard/danmemfix

bc52eb1

Merge master into memory-leaks

molnard requested changes Mar 25, 2019

View reviewed changes

Dan Walmsley and others added 8 commits March 25, 2019 17:42

Merge remote-tracking branch 'origin/master' into fixes/memory-leaks

0c68d79

dispose cancellation token source in cannot close dialog.

182fa4b

removed duplicate line.

fb47a56

fix lurking wife mode memory leak.

340fe33

fix double creation of reactive command.

c69266b

fix code factor issues.

fef4a73

fix memleak on walletinfotab

54a070d

Merge pull request #5 from molnard/infotabmemleak

5b0e332

fix memleak on walletinfotab

nopara73 merged commit c814b8c into zkSNACKs:master Mar 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Further memory leak fixes #1212

Further memory leak fixes #1212

danwalmsley commented Mar 7, 2019 •

edited by nopara73

nopara73 commented Mar 7, 2019

molnard left a comment

lontivero commented Mar 9, 2019

lontivero commented Mar 9, 2019

molnard commented Mar 19, 2019 •

edited

danwalmsley commented Mar 19, 2019

danwalmsley commented Mar 19, 2019

molnard commented Mar 21, 2019

danwalmsley commented Mar 21, 2019

molnard commented Mar 22, 2019

molnard left a comment

molnard Mar 25, 2019

danwalmsley Mar 25, 2019

molnard Mar 25, 2019

danwalmsley Mar 25, 2019

molnard Mar 25, 2019

molnard Mar 25, 2019

danwalmsley Mar 25, 2019

molnard commented Mar 25, 2019

Further memory leak fixes #1212

Further memory leak fixes #1212

Conversation

danwalmsley commented Mar 7, 2019 • edited by nopara73

nopara73 commented Mar 7, 2019

molnard left a comment

Choose a reason for hiding this comment

lontivero commented Mar 9, 2019

lontivero commented Mar 9, 2019

molnard commented Mar 19, 2019 • edited

danwalmsley commented Mar 19, 2019

danwalmsley commented Mar 19, 2019

molnard commented Mar 21, 2019

danwalmsley commented Mar 21, 2019

molnard commented Mar 22, 2019

molnard left a comment

Choose a reason for hiding this comment

molnard Mar 25, 2019

Choose a reason for hiding this comment

danwalmsley Mar 25, 2019

Choose a reason for hiding this comment

molnard Mar 25, 2019

Choose a reason for hiding this comment

danwalmsley Mar 25, 2019

Choose a reason for hiding this comment

molnard Mar 25, 2019

Choose a reason for hiding this comment

molnard Mar 25, 2019

Choose a reason for hiding this comment

danwalmsley Mar 25, 2019

Choose a reason for hiding this comment

molnard commented Mar 25, 2019

danwalmsley commented Mar 7, 2019 •

edited by nopara73

molnard commented Mar 19, 2019 •

edited