Allow P2PKH and P2SH scripts in coinjoin outputs
#12190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, how about segwit v0 script P2WSH? |
One step at a time. |
|
Concept ACK. With pay in coinjoins combined with big coinjoins of WabiSabi this makes sense. |
turbolay
approved these changes
Jan 4, 2024
|
|
||
| [DefaultValue(false)] | ||
| [JsonProperty(PropertyName = "AllowP2shOutputs", DefaultValueHandling = DefaultValueHandling.Populate)] | ||
| public bool AllowP2shOutputs { get; set; } = false; |
There was a problem hiding this comment.
Why false by default? Is there some cases where it would be annoying for a coordinator to have this? I can only see upsides.
There was a problem hiding this comment.
Yes, you're right. Next PR will switch them to true.
adamPetho
approved these changes
Jan 5, 2024
|
Partially closes #12189 |
With |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to register more scriptpubkyes to enable more use cases for coinjoins