Knots version fixing and document update #12289

Whem · 2024-01-19T15:25:31Z

https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Documentation/WasabiSetupRegtest.md was outdated

kristapsk · 2024-01-19T15:59:35Z

WalletWasabi.Documentation/WasabiSetupRegtest.md

@@ -9,9 +9,11 @@ You do not need to download the blockchain for this setup!

 Bitcoin Knots is working very similarly to Bitcoin Core. You can get a grasp with [this guide](https://bitcoin.org/en/developer-examples).

+WalletWasabi RegTest currently only works with Knots 21.2(LTS).


Is this true? For mainnet and testnet we use 23.0 on backend servers currently, regtest should work with that too.

I think he is talking about knots integrated into Wasabi, in which case the PR is not correct.

This week , I tried to install the Local Regtest system from this document. The newest Bitcoin Knots is 25.1 and after I installed that, so many things are changed and we can't configure it with @MarnixCroes. David said to us, then we need to fix the version number which definitely works on every platfrom if you would like to build up from this document.

25.1 haven't been properly tested with mainnet / testnet backends too, but 23.0 is.

ok, then I'll ask for some time and then I'll correct the wording as well. But the most important thing is to fix the version number, because there will be an error with the latest installer.

We should use the same on RegTest as the client which is 21.2. I am sharing the same data folder when using RegTest and Wasabi full node integration.

There's open PR to upgrade Knots to 25.1. Probably should open separate PR to upgrade to 23.0 first? #11964

I reopened #8825 to upgrade to 23.0 if needed.

knots version fixing

molnard · 2024-01-22T11:22:47Z

WalletWasabi.Documentation/WasabiSetupRegtest.md

 Todo:

-1. Install [Bitcoin Knots](https://bitcoinknots.org/) on your computer. Verify the PGP - there is a tutorial [here](https://bitcoinknots.org/)
+1. Install [Bitcoin Knots 21.2](https://bitcoinknots.org/files/21.x/21.2.knots20210629/) or [Bitcoin Knots 23.0](https://bitcoinknots.org/files/23.x/23.0.knots20220529/) on your computer. Verify the PGP - there is a tutorial [here](https://bitcoinknots.org/)


23.0 works with the same config file, data folder and you can generate new addresses? Did you test that?

yes, I used the same installation steps. No differences

I previously sent a comment but deleted it to provide a more precise description

On MacOs Silicon (and my machine):

For both version:

I had the extra step: Try to open, close error message, Settings -> Privacy And Security -> Scrolll down -> Open Anyway

-datadir should be: "$HOME/Library/Application Support/Bitcoin"

I had the extra step: Open terminal, cd "$HOME/Library/Application Support/Bitcoin", nano bitcoin.conf, paste the conf. The reason is that the file was not created by itself

For 21.2:

Make sure I didn't have already an existing Bitcoin folder (maybe because I was trying to downgrade, not sure)

For 23.0:

The Silicon package didn't work, only the Intel one.

Add the line regtest.listenonion = 0 in bitcoin.conf

Then, with both version, I could create addresses and receive funds

maybe the best option is to make a script for each platform that does the steps? And then at the beginning there is a choice of which node you want to install and then we will automate it? If this is necessary, I will gladly do it.

turbolay

Can you please also:

Change -datadir on Mac to "$HOME/Library/Application Support/Bitcoin". It's probably incorrect on Linux as well
Add regtest.listenonion = 0 to bitcoin.conf template. This can't hurt and the Tor problem on 23.0 was really annoying

maybe the best option is to make a script for each platform that does the steps?

Why not but your PR is already an improvement so let's merge it first

turbolay · 2024-01-22T13:30:07Z

WalletWasabi.Documentation/WasabiSetupRegtest.md

@@ -9,9 +9,11 @@ You do not need to download the blockchain for this setup!

 Bitcoin Knots is working very similarly to Bitcoin Core. You can get a grasp with [this guide](https://bitcoin.org/en/developer-examples).

+Currently, the latest version(25.1) is not tested, so the preferred versions are [21.2](https://github.com/bitcoinknots/bitcoin/releases/tag/v21.2.knots20210629) and [23.0](https://github.com/bitcoinknots/bitcoin/releases/tag/v23.0.knots20220529).


Suggested change

Currently, the latest version(25.1) is not tested, so the preferred versions are [21.2](https://github.com/bitcoinknots/bitcoin/releases/tag/v21.2.knots20210629) and [23.0](https://github.com/bitcoinknots/bitcoin/releases/tag/v23.0.knots20220529).

Preferred versions are [21.2](https://github.com/bitcoinknots/bitcoin/releases/tag/v21.2.knots20210629) and [23.0](https://github.com/bitcoinknots/bitcoin/releases/tag/v23.0.knots20220529) as later ones are currently not tested.

WalletWasabi.Documentation/WasabiSetupRegtest.md

molnard · 2024-01-24T16:17:00Z

WalletWasabi.Documentation/WasabiSetupRegtest.md

+
+     Windows x64:
+    ```
+    "C:\Program Files\Bitcoin\bitcoin-qt.exe" -regtest -blockfilterindex -txindex -datadir=c:\Bitcoin


Did you test this?

yes, but I preferred to move into the folder with the "cd" command

molnard · 2024-01-24T16:18:12Z

WalletWasabi.Documentation/WasabiSetupRegtest.md

-1. Install [Bitcoin Knots](https://bitcoinknots.org/) on your computer. Verify the PGP - there is a tutorial [here](https://bitcoinknots.org/)
-2. Start Bitcoin Knots with: bitcoin-qt.exe -regtest then quit immediately. In this way the data directory and the config files will be generated.
+1. Install [Bitcoin Knots 23.0](https://bitcoinknots.org/files/23.x/23.0.knots20220529/) on your computer. Verify the PGP - there is a tutorial [here](https://bitcoinknots.org/)
+2. Start Bitcoin Knots with: bitcoin-qt.exe -regtest then quit immediately. In this way the data directory and the config files will be generated. If you write "-datadir" parameter,make sure the directory exists


bitcoin-qt.exe

Did you test this?

yahiheb

Small nits:

WalletWasabi.Documentation/WasabiSetupRegtest.md

yahiheb · 2024-01-24T19:33:37Z

WalletWasabi.Documentation/WasabiSetupRegtest.md

+    ```
+    Linux: 
+    ```
+     ~/bitcoin-[version number]/bin/bitcoin-qt -regtest -blockfilterindex -txindex -datadir=c:\Bitcoin


-datadir=c:\Bitcoin

AFAIK there is no C directory in Linux, so this should be corrected.

Yes, there definitely isn't. Usually either $HOME/.bitcoin (default, no need to specify) or /var/lib/bitcoind is used. Same applies also to macOS too, although I'm not sure about exact paths there. C:\ is Windows specific.

WalletWasabi.Documentation/WasabiSetupRegtest.md

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>

molnard

Knots version fixing and document update

8a5205c

pull-request-size bot added the size/XS label Jan 19, 2024

Whem requested review from MarnixCroes and molnard January 19, 2024 15:25

kristapsk reviewed Jan 19, 2024

View reviewed changes

Update WasabiSetupRegtest.md

f7a0090

knots version fixing

Whem requested review from kristapsk and turbolay January 22, 2024 11:03

molnard requested changes Jan 22, 2024

View reviewed changes

turbolay reviewed Jan 22, 2024

View reviewed changes

foramt fixes and kntos version fixing

c9157cd

pull-request-size bot added size/M and removed size/XS labels Jan 24, 2024

config file and macos datadir path change

a0b3f68

Whem requested review from turbolay and molnard January 24, 2024 14:44

molnard requested changes Jan 24, 2024

View reviewed changes

WalletWasabi.Documentation/WasabiSetupRegtest.md Outdated Show resolved Hide resolved

molnard requested changes Jan 24, 2024

View reviewed changes

yahiheb requested changes Jan 24, 2024

View reviewed changes

Whem and others added 4 commits January 27, 2024 00:23

Update WalletWasabi.Documentation/WasabiSetupRegtest.md

ca0e586

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>

Update WalletWasabi.Documentation/WasabiSetupRegtest.md

f9215c5

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>

Update WalletWasabi.Documentation/WasabiSetupRegtest.md

28e5259

Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>

Fix typo and more data

7a04875

Whem requested a review from molnard January 31, 2024 08:18

molnard approved these changes Feb 1, 2024

View reviewed changes

molnard merged commit a3e4c68 into WalletWasabi:master Feb 1, 2024
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Knots version fixing and document update #12289

Knots version fixing and document update #12289

Whem commented Jan 19, 2024

kristapsk Jan 19, 2024

turbolay Jan 19, 2024

Whem Jan 19, 2024

kristapsk Jan 19, 2024

Whem Jan 19, 2024 •

edited

molnard Jan 22, 2024

kristapsk Jan 22, 2024

yahiheb Jan 24, 2024

molnard Jan 22, 2024 •

edited

Whem Jan 22, 2024

turbolay Jan 22, 2024 •

edited

Whem Jan 22, 2024 •

edited

turbolay left a comment

turbolay Jan 22, 2024

molnard Jan 24, 2024

Whem Jan 26, 2024

molnard Jan 24, 2024

Whem Jan 26, 2024

yahiheb left a comment

yahiheb Jan 24, 2024

kristapsk Jan 24, 2024

molnard left a comment

		@@ -9,9 +9,11 @@ You do not need to download the blockchain for this setup!

		Bitcoin Knots is working very similarly to Bitcoin Core. You can get a grasp with [this guide](https://bitcoin.org/en/developer-examples).

		WalletWasabi RegTest currently only works with Knots 21.2(LTS).

		@@ -9,9 +9,11 @@ You do not need to download the blockchain for this setup!

		Bitcoin Knots is working very similarly to Bitcoin Core. You can get a grasp with [this guide](https://bitcoin.org/en/developer-examples).

		Currently, the latest version(25.1) is not tested, so the preferred versions are [21.2](https://github.com/bitcoinknots/bitcoin/releases/tag/v21.2.knots20210629) and [23.0](https://github.com/bitcoinknots/bitcoin/releases/tag/v23.0.knots20220529).

	Currently, the latest version(25.1) is not tested, so the preferred versions are [21.2](https://github.com/bitcoinknots/bitcoin/releases/tag/v21.2.knots20210629) and [23.0](https://github.com/bitcoinknots/bitcoin/releases/tag/v23.0.knots20220529).
	Preferred versions are [21.2](https://github.com/bitcoinknots/bitcoin/releases/tag/v21.2.knots20210629) and [23.0](https://github.com/bitcoinknots/bitcoin/releases/tag/v23.0.knots20220529) as later ones are currently not tested.

Knots version fixing and document update #12289

Knots version fixing and document update #12289

Conversation

Whem commented Jan 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Whem Jan 19, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

molnard Jan 22, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turbolay Jan 22, 2024 • edited

Choose a reason for hiding this comment

Whem Jan 22, 2024 • edited

Choose a reason for hiding this comment

turbolay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yahiheb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

molnard left a comment

Choose a reason for hiding this comment

Whem Jan 19, 2024 •

edited

molnard Jan 22, 2024 •

edited

turbolay Jan 22, 2024 •

edited

Whem Jan 22, 2024 •

edited