[VDG] Close the Success dialog automatically #12312

wieslawsoltes · 2024-01-24T15:32:32Z

…se-the-dialog-automatically

soosr

cACK

The autoclosing should be also applied to the SuccessViewModel.
And both view (SuccessView, AddedWalletPageView) should only contain an animating checkmark. Basically, exactly how is it in SuccessView (without the text).

…se-the-dialog-automatically

MarnixCroes

tested lgtm daf679a

a29bc69 good👍, at prior commits the animation was too short for me

soosr · 2024-01-31T13:59:35Z

@wieslawsoltes Just found that SendSuccessViewModel should also be modified.

yahiheb

tACK

wieslawsoltes · 2024-02-01T09:14:34Z

@wieslawsoltes Just found that SendSuccessViewModel should also be modified.

@soosr done 22a7418

yahiheb

tACK

MarnixCroes

22a7418 the closure is too fast
I'm unable to read all the text which gives me bad UX

soosr · 2024-02-01T12:13:15Z

I'm unable to read all the text which gives me bad UX

There shouldn't be text, just the checkmark.

wieslawsoltes · 2024-02-01T12:21:51Z

I'm unable to read all the text which gives me bad UX

There shouldn't be text, just the checkmark.

Remove text 284cfbe

soosr

first round of review

WalletWasabi.Fluent/ViewModels/SuccessViewModel.cs

WalletWasabi.Fluent/ViewModels/AddWallet/AddedWalletPageViewModel.cs

WalletWasabi.Fluent/Views/AddWallet/AddedWalletPageView.axaml

WalletWasabi.Fluent/Views/SuccessView.axaml

soosr · 2024-02-01T13:11:07Z

WalletWasabi.Fluent/Views/Wallets/Send/SendSuccessView.axaml

@@ -4,20 +4,15 @@
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             xmlns:c="using:WalletWasabi.Fluent.Controls"
             xmlns:vm="using:WalletWasabi.Fluent.ViewModels.Wallets.Send"
+             xmlns:views="clr-namespace:WalletWasabi.Fluent.Views"
             mc:Ignorable="d"
             x:DataType="vm:SendSuccessViewModel"
             x:CompileBindings="True"
             x:Class="WalletWasabi.Fluent.Views.Wallets.Send.SendSuccessView">
  <c:ContentArea Title="{Binding Title}"


Title can be removed

That commit doesn't remove the title from this view.

WalletWasabi.Fluent/ViewModels/Wallets/Send/SendSuccessViewModel.cs

soosr

Final review:

Don't forget this: [VDG] Close the Success dialog automatically #12312 (comment)
Can you create a variable for the delay time and use that everywhere?
- (or make the other dialogs to inherit from SuccesViewModel, and just have the delay there?) Up to you.
Please increase the delay time to 1000s ([VDG] Close the Success dialog automatically #12312 (comment))

WalletWasabi.Fluent/Views/SuccessAnimationView.axaml

wieslawsoltes · 2024-02-02T07:56:33Z

Final review:

Don't forget this: [VDG] Close the Success dialog automatically #12312 (comment)

633e437

Can you create a variable for the delay time and use that everywhere?

0e07f11

(or make the other dialogs to inherit from SuccesViewModel, and just have the delay there?) Up to you.

Please increase the delay time to 1000s ([VDG] Close the Success dialog automatically #12312 (comment))

388b582

WalletWasabi.Fluent/UiConstants.cs

soosr

tACK

wieslawsoltes added 3 commits January 24, 2024 16:31

Execute the next command automatically and close the dialog

b629c4e

Hide the next button

4939006

Reset IsBusy and show for a while the success message

590bc91

pull-request-size bot added the size/S label Jan 24, 2024

Merge remote-tracking branch 'upstream/master' into vdg/fix-11568-clo…

5a1cb30

…se-the-dialog-automatically

wieslawsoltes marked this pull request as ready for review January 28, 2024 12:23

wieslawsoltes marked this pull request as draft January 28, 2024 12:26

wieslawsoltes marked this pull request as ready for review January 28, 2024 12:29

Merge remote-tracking branch 'upstream/master' into vdg/fix-11568-clo…

501b7a4

…se-the-dialog-automatically

wieslawsoltes changed the title ~~Close the Success dialog automatically~~ [VDG] Close the Success dialog automatically Jan 29, 2024

soosr requested changes Jan 30, 2024

View reviewed changes

wieslawsoltes and others added 2 commits January 30, 2024 12:46

Merge remote-tracking branch 'upstream/master' into vdg/fix-11568-clo…

5c535f3

…se-the-dialog-automatically

Show animated checkmark in AddedWalletPageView

3369f9a

pull-request-size bot added size/M and removed size/S labels Jan 30, 2024

wieslawsoltes added 2 commits January 30, 2024 19:58

Increase display time

a29bc69

Auto closer success view

daf679a

MarnixCroes approved these changes Jan 30, 2024

View reviewed changes

yahiheb previously approved these changes Jan 31, 2024

View reviewed changes

Auto close SendSuccessViewModel dialog

22a7418

wieslawsoltes dismissed yahiheb’s stale review via 22a7418 February 1, 2024 09:14

pull-request-size bot added size/L and removed size/M labels Feb 1, 2024

yahiheb previously approved these changes Feb 1, 2024

View reviewed changes

MarnixCroes suggested changes Feb 1, 2024

View reviewed changes

Remove success text

284cfbe

wieslawsoltes dismissed yahiheb’s stale review via 284cfbe February 1, 2024 12:21

soosr reviewed Feb 1, 2024

View reviewed changes

wieslawsoltes added 3 commits February 1, 2024 17:10

Remove SuccessText

c049c29

Remove Title

85cb0cf

Remove Title

442b661

turbolay reviewed Feb 1, 2024

View reviewed changes

WalletWasabi.Fluent/ViewModels/Wallets/Send/SendSuccessViewModel.cs Outdated Show resolved Hide resolved

soosr requested changes Feb 2, 2024

View reviewed changes

WalletWasabi.Fluent/Views/SuccessAnimationView.axaml Outdated Show resolved Hide resolved

wieslawsoltes added 3 commits February 2, 2024 08:49

Increase delay before closing send success dialog

388b582

Remove title from SendSuccessView

633e437

Add close dialog delays to UiConstants

0e07f11

Adjust animation for success views

8f4e887

soosr reviewed Feb 2, 2024

View reviewed changes

WalletWasabi.Fluent/UiConstants.cs Outdated Show resolved Hide resolved

Use only one variable for all dialogs

2cd14d2

soosr approved these changes Feb 2, 2024

View reviewed changes

soosr merged commit c1d664a into WalletWasabi:master Feb 2, 2024
4 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VDG] Close the Success dialog automatically #12312

[VDG] Close the Success dialog automatically #12312

wieslawsoltes commented Jan 24, 2024

soosr left a comment

MarnixCroes left a comment

soosr commented Jan 31, 2024

yahiheb left a comment

wieslawsoltes commented Feb 1, 2024

yahiheb left a comment

MarnixCroes left a comment

soosr commented Feb 1, 2024

wieslawsoltes commented Feb 1, 2024

soosr left a comment

soosr Feb 1, 2024

wieslawsoltes Feb 1, 2024

soosr Feb 2, 2024

soosr left a comment

wieslawsoltes commented Feb 2, 2024

soosr left a comment

[VDG] Close the Success dialog automatically #12312

[VDG] Close the Success dialog automatically #12312

Conversation

wieslawsoltes commented Jan 24, 2024

soosr left a comment

Choose a reason for hiding this comment

MarnixCroes left a comment

Choose a reason for hiding this comment

soosr commented Jan 31, 2024

yahiheb left a comment

Choose a reason for hiding this comment

wieslawsoltes commented Feb 1, 2024

yahiheb left a comment

Choose a reason for hiding this comment

MarnixCroes left a comment

Choose a reason for hiding this comment

soosr commented Feb 1, 2024

wieslawsoltes commented Feb 1, 2024

soosr left a comment

Choose a reason for hiding this comment

soosr Feb 1, 2024

Choose a reason for hiding this comment

wieslawsoltes Feb 1, 2024

Choose a reason for hiding this comment

soosr Feb 2, 2024

Choose a reason for hiding this comment

soosr left a comment

Choose a reason for hiding this comment

wieslawsoltes commented Feb 2, 2024

soosr left a comment

Choose a reason for hiding this comment