Satoshi notifications #12400
Satoshi notifications #12400
Conversation
lontivero
force-pushed
the
index-ws
branch
3 times, most recently
from
9a22688
to
a7708f8
Compare
|
Recommendation for reviewers:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
@turbolay created a test server where we can properly test this, so I'll do live testing and see if it all goes well. |
| } | ||
| } | ||
|
|
||
| async Task RewindAsync(int count) |
There was a problem hiding this comment.
If this tries to remove more filters than what we have, IndexStore throws and the client is bricked (doesn't try to connect to backend anymore)
There was a problem hiding this comment.
Good catch. I will take a look.
| BlockHeight, | ||
| ExchangeRate, | ||
| MiningFeeRates | ||
| } |
There was a problem hiding this comment.
Why is this in a file named FilterMessage? Confusing
|
I pushed some commits to fix the issues I found. |
|
I tested it 2 weeks ago when regtest server was set, didn't find any problems or errors, will do another round of testing with the new changes. |
|
At the CODE team meeting, we agreed to have this after the release of v2.0.7. |
…xchangeRate` and `MiningFeeRate`
|
@turbolay I have rebased this branch on top of the released version and I have removed the merges and the commit fixing merging problems and so on. The idea is that the branch it already too big and I would like to keep it clean. @turbolay @Szpoti if this PR can be merged please approve it, otherwise let me know what is missing. |
This reverts commit 79b8cf7.
Push notifications for Satoshi identity using web sockets.
This PR is for the coordinator to send notifications about changes such as mining fee rates, exchange rates, new filters, round state changes, etc to all the clients. In this way clients don't need to request information using long pooling, instead the simple listen passively and get notifications about different events as soon as those occurs.
Websocket infrastructure
The new server-side infrastructure components are mostly in the Backend's middleware folder. The solution is implemented as a ASP.NET middleware and it looks pretty much as a socket server implementation were after receiving a http request, if it is a protocol upgrade (websocket) request it accepts the connection, register the websocket in a list of websockets and start listening for messages from the connected client. The implementation is pretty generic because the idea is to have a reusable infra for implementing websocket communication for other identities too (Alice is the best candidate here)
Satoshi messages
All what can be known by satoshi is implemented by the
SatoshiWebSocketHandlerhandler. This sends mining fee rates, exchange rates and compact filters as soon as they are created.Upon establishing the connection, the client transmits the hash of the most recent known block to the coordinator, enabling the latter to start sending filters from that specific hash onwards. After all filters have been sent, it subscribes the socket to receive all new filters.
Note: Continuing with this PR requires lots of changes in many places and for that reason I think it will be better to start changing small things before even doing any further progress.
Fixes: #12117