Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Fix TreeDataGridPrivacyTextCell rendering #12510

Merged
merged 4 commits into from Feb 21, 2024
Merged

[VDG] Fix TreeDataGridPrivacyTextCell rendering #12510

merged 4 commits into from Feb 21, 2024

Conversation

wieslawsoltes
Copy link
Collaborator

Fixes #12509

MarnixCroes
MarnixCroes reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all columns should have the chars
not only the one's with text

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 21, 2024
@wieslawsoltes
Copy link
Collaborator Author

all columns should have the chars not only the one's with text

@MarnixCroes Pushed fix a75ead3

MarnixCroes
MarnixCroes approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack a75ead3

soosr
soosr approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 7c289a5 into zkSNACKs:master Feb 21, 2024
3 of 6 checks passed
@soosr soosr mentioned this pull request Feb 21, 2024
Merged
@wieslawsoltes wieslawsoltes deleted the vdg/12509-fix-TreeDataGridPrivacyTextCell-rendering branch February 21, 2024 11:09
@wieslawsoltes wieslawsoltes mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/M
Projects
No open projects
Merge to v2.0.6 release branch
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[release] [UI] History: Discreet mode: privacychars sometimes missing at receive column
3 participants
@wieslawsoltes @soosr @MarnixCroes