[VDG] Privacy Ring - Remove Carousel #12541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ichthus1604
commented
Feb 22, 2024
ichthus1604
commented
- Removes Carousel UI element from Privacy Ring view
- Fade in animation has been temporarily disabled to prevent the glitches. Will restore it in a future PR.
- Fixes [UI] Privacy Progress: Light flickering when hovering out of a coin #12537
- Attempt to fix [UI] Glitch above privacy percentage in privacy progress dialog #12495. I could not reproduce this issue so I'm not sure 100% that it's fixed in this PR. @yahiheb can you confirm?
| PreviewItems.Add(PrivacyTile); | ||
| // Show PrivacyTile info when SelectedItem is null | ||
| Observable.Return(Unit.Default) | ||
| .Delay(TimeSpan.FromMilliseconds(750)) // Wait for Ring animation to render |
There was a problem hiding this comment.
Yeah, this is not correct. The Delay should take into account the number of segments that need to be rendered.
There was a problem hiding this comment.
Left a TODO comment and disabled it for now
|
It fixes #12537 |
wieslawsoltes
requested changes
Feb 22, 2024
yahiheb
reviewed
Feb 22, 2024
Fixed. |
soosr
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.